Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: update iroha_torii_macro to use syn 2.0 #4118

Merged
merged 7 commits into from
Jan 11, 2024
Merged

[refactor]: update iroha_torii_macro to use syn 2.0 #4118

merged 7 commits into from
Jan 11, 2024

Conversation

VAmuzing
Copy link
Contributor

@VAmuzing VAmuzing commented Dec 7, 2023

Description

A part of #3682

Seems like we do not need to introduce manyhow and darling for this crate

Linked issue

Closes #4117

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@VAmuzing VAmuzing self-assigned this Dec 7, 2023
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 7, 2023
@VAmuzing VAmuzing changed the title Update iroha_cli_derive to use syn 2.0 [refactor]: update iroha_cli to use syn 2.0 Dec 7, 2023
@coveralls
Copy link

coveralls commented Dec 7, 2023

Pull Request Test Coverage Report for Build 7192274772

  • 17 of 18 (94.44%) changed or added relevant lines in 1 file are covered.
  • 7111 unchanged lines in 125 files lost coverage.
  • Overall coverage decreased (-3.3%) to 56.089%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/derive/src/lib.rs 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
core/src/smartcontracts/isi/block.rs 1 87.5%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
config/src/logger.rs 3 92.68%
data_model/derive/src/has_origin.rs 3 95.16%
data_model/src/events/execute_trigger.rs 3 30.77%
data_model/src/peer.rs 3 47.62%
ffi/src/ir.rs 3 80.0%
ffi/src/lib.rs 3 93.46%
Totals Coverage Status
Change from base Build 5423219773: -3.3%
Covered Lines: 22765
Relevant Lines: 40587

💛 - Coveralls

@VAmuzing VAmuzing changed the title [refactor]: update iroha_cli to use syn 2.0 [refactor]: update iroha_cli_derive to use syn 2.0 Dec 7, 2023
@DCNick3 DCNick3 self-assigned this Dec 7, 2023
@DCNick3
Copy link
Contributor

DCNick3 commented Dec 8, 2023

Seems like we do not need to introduce manyhow and darling for this crate

There's definitely no use for darling here, but I still prefer to use manyhow in macros that don't return errors, as it handles the proc_macro2::TokenStream to proc_macro::TokenStream conversion, allowing us to not mention any proc_macro types.

@ilchu ilchu self-assigned this Dec 11, 2023
@VAmuzing
Copy link
Contributor Author

There's definitely no use for darling here, but I still prefer to use manyhow in macros that don't return errors, as it handles the proc_macro2::TokenStream to proc_macro::TokenStream conversion, allowing us to not mention any proc_macro types.

Done!
Added manyhow to the project.

@DCNick3
Copy link
Contributor

DCNick3 commented Dec 12, 2023

The code is good, although the first two commits are missing sign-offs.

Here's a seemingly sane guide onto how that can be done retroactively

DCNick3
DCNick3 previously approved these changes Dec 13, 2023
@VAmuzing VAmuzing requested a review from DCNick3 December 22, 2023 02:18
@0x009922 0x009922 changed the title [refactor]: update iroha_cli_derive to use syn 2.0 [refactor]: update iroha_torii_macro to use syn 2.0 Dec 22, 2023
@VAmuzing VAmuzing mentioned this pull request Dec 23, 2023
12 tasks
@AlexStroke AlexStroke closed this Jan 9, 2024
@AlexStroke AlexStroke reopened this Jan 9, 2024
@mversic mversic assigned mversic and unassigned ilchu Jan 11, 2024
@VAmuzing VAmuzing merged commit f6593ee into hyperledger-iroha:iroha2-dev Jan 11, 2024
8 of 9 checks passed
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 22, 2024
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants