Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] #4099: Fix of the websocket request builder #4114

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[fix] #4099: Fix of the websocket request builder #4114

merged 1 commit into from
Dec 6, 2023

Conversation

Stukalov-A-M
Copy link
Contributor

@Stukalov-A-M Stukalov-A-M commented Dec 4, 2023 •
edited
Loading

Description

Fixed the web socket bug which gives HTTP 400.
All library versions saved as-is

Linked issue

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 4, 2023
@Stukalov-A-M Stukalov-A-M force-pushed the fix_websocket_request_builder_dev branch 2 times, most recently from 10ca268 to b571572 Compare December 4, 2023 14:55
@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7104343465

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7015 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.302%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/http_default.rs 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23024
Relevant Lines: 40894
💛 - Coveralls

@Stukalov-A-M Stukalov-A-M force-pushed the fix_websocket_request_builder_dev branch from b571572 to 8639063 Compare December 4, 2023 17:26
Arjentix
Arjentix suggested changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Arjentix Arjentix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for PR to stable branch

client/src/http_default.rs Outdated Show resolved Hide resolved
@Arjentix Arjentix mentioned this pull request Dec 4, 2023
Merged
5 tasks
@Stukalov-A-M Stukalov-A-M force-pushed the fix_websocket_request_builder_dev branch from 8639063 to 38810db Compare December 5, 2023 17:26
@mversic mversic self-assigned this Dec 6, 2023
@Arjentix Arjentix merged commit 9b5559a into hyperledger-iroha:iroha2-dev Dec 6, 2023
8 checks passed
@Stukalov-A-M Stukalov-A-M deleted the fix_websocket_request_builder_dev branch December 7, 2023 14:06
mversic added a commit to mversic/iroha that referenced this pull request Dec 8, 2023
@mversic
Revert "[fix] hyperledger-iroha#4099: Fix of the websocket request bu…
6a59a47 
…ilder (hyperledger-iroha#4114)"

This reverts commit 9b5559a.

Signed-off-by: Marin Veršić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@Arjentix Arjentix Arjentix approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@Erigara Erigara Awaiting requested review from Erigara

@0x009922 0x009922 Awaiting requested review from 0x009922

@DCNick3 DCNick3 Awaiting requested review from DCNick3

Assignees

@Arjentix Arjentix

@mversic mversic

@Stukalov-A-M Stukalov-A-M

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Stukalov-A-M @coveralls @Arjentix @mversic