Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4080: Export data model through iroha_client #4081

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Nov 24, 2023

Description

Linked issue

Closes #4080

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 24, 2023
@coveralls
Copy link

coveralls commented Nov 24, 2023

Pull Request Test Coverage Report for Build 7057459847

  • 3 of 12 (25.0%) changed or added relevant lines in 3 files are covered.
  • 7026 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.2%) to 56.268%

Changes Missing Coverage Covered Lines Changed/Added Lines %
smart_contract/executor/src/default.rs 0 1 0.0%
client/src/client.rs 2 10 20.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.2%
Covered Lines: 23011
Relevant Lines: 40895

💛 - Coveralls

@mversic mversic force-pushed the re_export_data_model branch from 0c09043 to 5f665cd Compare November 24, 2023 12:58
@mversic mversic changed the title [feature] #4080: Export data model through iroha_client [refactor] #4080: Export data model through iroha_client Nov 24, 2023
@mversic mversic force-pushed the re_export_data_model branch from 5f665cd to b1455a5 Compare November 24, 2023 13:42
@mversic mversic self-assigned this Nov 24, 2023
Copy link
Contributor

@VAmuzing VAmuzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea
LGTM

@VAmuzing VAmuzing self-assigned this Nov 27, 2023
@ilchu ilchu self-assigned this Nov 27, 2023
@mversic mversic force-pushed the re_export_data_model branch from b1455a5 to e00d9ed Compare November 30, 2023 07:34
Copy link
Contributor

@ilchu ilchu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mversic mversic force-pushed the re_export_data_model branch from e00d9ed to c84d3ef Compare December 1, 2023 08:14
@mversic mversic merged commit 0ef18fe into hyperledger-iroha:iroha2-dev Dec 1, 2023
11 checks passed
@mversic mversic deleted the re_export_data_model branch December 1, 2023 09:48
mversic added a commit to mversic/iroha that referenced this pull request Dec 13, 2023
mversic added a commit to mversic/iroha that referenced this pull request Dec 13, 2023
mversic added a commit to mversic/iroha that referenced this pull request Dec 13, 2023
mversic added a commit to mversic/iroha that referenced this pull request Dec 13, 2023
mversic added a commit to mversic/iroha that referenced this pull request Dec 14, 2023
mversic added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants