Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: use AllAccountSignaturesAnd as default signature check condition #4067

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Nov 21, 2023

Description

I think this makes more sense as a default. But I'd like to hear differing opinions

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 21, 2023
@mversic mversic force-pushed the default_signature_check_condition branch from d9ec7f7 to 0d27b61 Compare November 21, 2023 12:14
@mversic mversic force-pushed the default_signature_check_condition branch from 0d27b61 to 24de52e Compare November 21, 2023 12:34
@mversic mversic closed this Nov 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6943851154

  • 62 of 77 (80.52%) changed or added relevant lines in 3 files are covered.
  • 6942 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.328%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/test_network/src/lib.rs 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23033
Relevant Lines: 40891

💛 - Coveralls

@mversic mversic deleted the default_signature_check_condition branch April 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants