Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: change parameters to more optimal values #4021

Closed
wants to merge 1 commit into from

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Oct 27, 2023

Description

more optimal values were found by @timofeevmd during perf testing

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 27, 2023
@mversic mversic force-pushed the optimal_params branch 2 times, most recently from 592d4a4 to c15c2e3 Compare October 31, 2023 09:31
Copy link
Contributor

@pesterev pesterev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but the branch has to be updated

config/iroha_test_config.json Show resolved Hide resolved
6r1d
6r1d previously approved these changes Nov 6, 2023
6r1d
6r1d previously approved these changes Nov 6, 2023
@mversic mversic requested a review from pesterev November 6, 2023 07:00
@coveralls
Copy link

coveralls commented Nov 6, 2023

Pull Request Test Coverage Report for Build 6943888574

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 6919 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cli/src/samples.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23015
Relevant Lines: 40841

💛 - Coveralls

pesterev
pesterev previously approved these changes Nov 8, 2023
@pesterev
Copy link
Contributor

Let's rebase it

VAmuzing
VAmuzing previously approved these changes Nov 13, 2023
@mversic mversic dismissed stale reviews from VAmuzing and pesterev via 2a85a95 November 21, 2023 12:37
@mversic mversic closed this Dec 14, 2023
@mversic mversic deleted the optimal_params branch April 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants