-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: change parameters to more optimal values #4021
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
October 27, 2023 10:29
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Oct 27, 2023
mversic
force-pushed
the
optimal_params
branch
2 times, most recently
from
October 31, 2023 09:31
592d4a4
to
c15c2e3
Compare
pesterev
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good but the branch has to be updated
mversic
force-pushed
the
optimal_params
branch
from
November 6, 2023 06:38
c15c2e3
to
f716ca8
Compare
6r1d
previously approved these changes
Nov 6, 2023
mversic
force-pushed
the
optimal_params
branch
from
November 6, 2023 06:58
f716ca8
to
f4db037
Compare
6r1d
previously approved these changes
Nov 6, 2023
Pull Request Test Coverage Report for Build 6943888574
💛 - Coveralls |
mversic
force-pushed
the
optimal_params
branch
from
November 7, 2023 11:51
f4db037
to
0922950
Compare
pesterev
previously approved these changes
Nov 8, 2023
Let's rebase it |
VAmuzing
previously approved these changes
Nov 13, 2023
…perf testing Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
optimal_params
branch
from
November 21, 2023 12:37
0922950
to
2a85a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
more optimal values were found by @timofeevmd during perf testing
Linked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md