fix variable error #4020
Merged
fix variable error #4020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appetrosyan
reviewed
Jan 10, 2024
appetrosyan
previously approved these changes
Jan 10, 2024
Signed-off-by: xiaolou86 <[email protected]>
Signed-off-by: xiaolou86 <[email protected]>
appetrosyan
had a problem deploying
to
test-env
GitHub Actions
Failure
appetrosyan
had a problem deploying
to
test-env
GitHub Actions
Failure
appetrosyan
had a problem deploying
to
test-env
GitHub Actions
Failure
appetrosyan
had a problem deploying
to
test-env
GitHub Actions
Failure
Co-authored-by: Aleksandr Petrosyan <[email protected]> Signed-off-by: xiaolou86 <[email protected]>
|
@appetrosyan Thanks for your review. I have added the Suggested change. |
xiaolou86
commented
Jan 11, 2024
Signed-off-by: xiaolou86 <[email protected]>
baziorek
requested changes
Jan 11, 2024
|
@baziorek thank you very much for your review. |
|
@appetrosyan @baziorek thanks for your reviews. Could you help to merge? |
It was merged already by @6r1d . Thanks @xiaolou86 for Your work! |
dominious1
pushed a commit
to dominious1/iroha
that referenced
this pull request
Feb 1, 2024
* docs: fix typos Signed-off-by: xiaolou86 <[email protected]> * fix variable error Signed-off-by: xiaolou86 <[email protected]> * Fix typo in CMakeLists.txt Co-authored-by: Aleksandr Petrosyan <[email protected]> Signed-off-by: xiaolou86 <[email protected]> * fix typo in docs/source/build/index.rst Signed-off-by: xiaolou86 <[email protected]> --------- Signed-off-by: xiaolou86 <[email protected]> Co-authored-by: Aleksandr Petrosyan <[email protected]> Signed-off-by: dominious1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example/burrow_integration/permissions.py