-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3822, #3737, #2437: Refactor iroha_data_model_derive #3897
Merged
DCNick3
merged 9 commits into
hyperledger-iroha:iroha2-dev
from
DCNick3:syn2-iroha-data-model
Sep 26, 2023
Merged
[refactor] #3822, #3737, #2437: Refactor iroha_data_model_derive #3897
DCNick3
merged 9 commits into
hyperledger-iroha:iroha2-dev
from
DCNick3:syn2-iroha-data-model
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Sep 18, 2023
DCNick3
changed the title
Rafactor iroha_data_model_derive
[refactor] #3822, #3737, #2437: Refactor iroha_data_model_derive
Sep 18, 2023
Pull Request Test Coverage Report for Build 6308478360
💛 - Coveralls |
4 tasks
Arjentix
reviewed
Sep 18, 2023
DCNick3
force-pushed
the
syn2-iroha-data-model
branch
3 times, most recently
from
September 20, 2023 07:14
df72005
to
f7549a2
Compare
DCNick3
requested review from
s8sato,
appetrosyan,
mversic,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara and
0x009922
as code owners
September 21, 2023 07:56
ilchu
previously approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides very minor points.
2 tasks
DCNick3
force-pushed
the
syn2-iroha-data-model
branch
from
September 25, 2023 11:10
f7549a2
to
8a3fd04
Compare
ilchu
approved these changes
Sep 25, 2023
Arjentix
approved these changes
Sep 25, 2023
…use syn 2.0 Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Nikita Strygin <[email protected]>
…ng, add tests Signed-off-by: Nikita Strygin <[email protected]>
…rialize use darling Signed-off-by: Nikita Strygin <[email protected]>
…in serde partially tagged enums Signed-off-by: Nikita Strygin <[email protected]>
….filter_maps & get rid of unnecessary .except in derive(Filter) This addresses the last of the concerns raised in hyperledger-iroha#2437 Signed-off-by: Nikita Strygin <[email protected]>
…cro, reduce repetition in derive(IdEqOrdHash), fix error reporting on stable Signed-off-by: Nikita Strygin <[email protected]>
…n to make clippy happy Signed-off-by: Nikita Strygin <[email protected]>
…ive(HasOrigin)` Signed-off-by: Nikita Strygin <[email protected]>
mversic
force-pushed
the
syn2-iroha-data-model
branch
from
September 26, 2023 05:28
5d6b534
to
71f92ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces various improvements to
iroha_data_model_derive
:Self
type in serde partially tagged enums (Unfortunately, currently it's limitation of partially tagged (de)serialize macros. #3737)derive(Filter)
outlined in Refactor#[derive(Filter)]
for better parsing and readability #2437[1] I am a bit unhappy with the testing of
derive(Filter)
, but it seems so intertwined with all the parts ofiroha_data_model
that it's really hard to test. Additionally, testing the generatedFilter
impl requires thetransparent_api
featureLinked issue
Closes #3882, #3737, #2437
Checklist