fix: make sure that chacha20poly1305::tests::decrypt_should_fail is n…

…ot flaky (#5031) Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
hyperledger-iroha · Sep 4, 2024 · a348b85 · a348b85
1 parent 36bbf04
commit a348b85
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/crypto/src/encryption/chacha20poly1305.rs b/crypto/src/encryption/chacha20poly1305.rs
@@ -104,10 +104,12 @@ mod tests {
         let mut ciphertext = res.unwrap();
 
         let aad = b"decrypt should succeed".to_vec();
+        // decrypt should fail because if mismatched aad
         cipher.decrypt_easy(&aad, &ciphertext).unwrap_err();
 
         let aad = b"decrypt should fail".to_vec();
-        ciphertext[0] ^= ciphertext[1];
+        ciphertext[0] ^= 0x01;
+        // decrypt should fail because of tampered ciphertext
         cipher.decrypt_easy(&aad, &ciphertext).unwrap_err();
     }