[refactor] migrate integration Rust tests to client cli pytests

Signed-off-by: alexstroke <[email protected]>

client/tests/integration/asset.rs

@@ -11,6 +11,10 @@ use iroha_primitives::fixed::Fixed;
 use serde_json::json;
 use test_network::*;
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test is deprecated and refers to test_register_asset_definitions.py"
+)]
 #[test]
 fn client_register_asset_should_add_asset_once_but_not_twice() -> Result<()> {
     let (_rt, _peer, test_client) = <PeerBuilder>::new().with_port(10_620).start_with_runtime();
@@ -89,6 +93,10 @@ fn unregister_asset_should_remove_asset_from_account() -> Result<()> {
 }
 
 #[test]
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test is deprecated and refers to test_mint_assets.py"
+)]
 fn client_add_asset_quantity_to_existing_asset_should_increase_asset_amount() -> Result<()> {
     let (_rt, _peer, test_client) = <PeerBuilder>::new().with_port(10_000).start_with_runtime();
     wait_for_genesis_committed(&[test_client.clone()], 0);
@@ -202,6 +210,10 @@ fn client_add_asset_with_decimal_should_increase_asset_amount() -> Result<()> {
 }
 
 #[test]
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test is deprecated and refers to test_register_asset_definitions.py"
+)]
 fn client_add_asset_with_name_length_more_than_limit_should_not_commit_transaction() -> Result<()> {
     let (_rt, _peer, test_client) = <PeerBuilder>::new().with_port(10_520).start_with_runtime();
     wait_for_genesis_committed(&[test_client.clone()], 0);

client/tests/integration/add_account.rs → client/tests/integration/deprecated_add_account.rs

@@ -5,6 +5,10 @@ use iroha_client::{client, data_model::prelude::*};
 use iroha_config::iroha::Configuration;
 use test_network::*;
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test suite is deprecated and refers to test_register_accounts.py"
+)]
 #[test]
 fn client_add_account_with_name_length_more_than_limit_should_not_commit_transaction() -> Result<()>
 {

client/tests/integration/add_domain.rs → client/tests/integration/deprecated_add_domain.rs

@@ -5,6 +5,10 @@ use iroha_client::{client, data_model::prelude::*};
 use iroha_config::iroha::Configuration;
 use test_network::*;
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test suite is deprecated and refers totest_register_domains.py"
+)]
 #[test]
 fn client_add_domain_with_name_length_more_than_limit_should_not_commit_transaction() -> Result<()>
 {

client/tests/integration/asset_propagation.rs → client/tests/integration/deprecated_asset_propagation.rs

@@ -12,6 +12,10 @@ use iroha_client::{
 use iroha_config::iroha::Configuration;
 use test_network::*;
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test is deprecated and refers to test_mint_asset.py"
+)]
 #[test]
 fn client_add_asset_quantity_to_existing_asset_should_increase_asset_amount_on_another_peer(
 ) -> Result<()> {

client/tests/integration/config.rs → client/tests/integration/extra_functional/deprecated_config.rs

@@ -1,6 +1,11 @@
 use iroha_client::data_model::Level;
 use test_network::*;
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test is meaningless since it doesn't test anything useful"
+)]
+#[ignore = "ignore, more in #4094"]
 #[test]
 fn config_endpoints() {
     const NEW_LOG_LEVEL: Level = Level::ERROR;

client/tests/integration/extra_functional/mod.rs

@@ -0,0 +1,7 @@
+mod connected_peers;
+mod deprecated_config;
+mod multiple_blocks_created;
+mod offline_peers;
+mod restart_peer;
+mod unregister_peer;
+mod unstable_network;

client/tests/integration/mod.rs

@@ -1,29 +1,22 @@
-mod add_account;
-mod add_domain;
 mod asset;
-mod asset_propagation;
 mod burn_public_keys;
-mod config;
-mod connected_peers;
-mod domain_owner;
+mod deprecated_add_account;
+mod deprecated_add_domain;
+mod deprecated_asset_propagation;
+mod domain_owner_permissions;
 mod events;
-mod multiple_blocks_created;
+mod extra_functional;
 mod multisignature_account;
 mod multisignature_transaction;
 mod non_mintable;
-mod offline_peers;
 mod pagination;
 mod permissions;
 mod queries;
-mod query_errors;
-mod restart_peer;
 mod roles;
 mod set_parameter;
 mod sorting;
 mod transfer_asset;
 mod triggers;
 mod tx_history;
 mod tx_rollback;
-mod unregister_peer;
-mod unstable_network;
 mod upgrade;

client/tests/integration/queries/mod.rs

@@ -12,6 +12,7 @@ use test_network::*;
 
 mod account;
 mod asset;
+mod query_errors;
 mod role;
 
 #[test]

client/tests/integration/transfer_asset.rs

@@ -6,6 +6,10 @@ use iroha_client::{
 use iroha_primitives::fixed::Fixed;
 use test_network::*;
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test suite is deprecated and refers to test_tranfer_assets.py"
+)]
 #[test]
 fn simulate_transfer_quantity() {
     simulate_transfer(
@@ -42,8 +46,12 @@ fn simulate_transfer_fixed() {
     )
 }
 
+#[deprecated(
+    since = "2.0.0-pre-rc.20",
+    note = "This test suite is deprecated, use test_tranfer_assets.py instead"
+)]
+#[ignore = "migrated to client cli python tests"]
 #[test]
-#[ignore = "long"]
 #[should_panic(expected = "insufficient funds")]
 fn simulate_insufficient_funds() {
     simulate_transfer(

client_cli/pytests/common/consts.py

@@ -22,7 +22,8 @@ class Stderr(Enum):
     INVALID_VALUE_TYPE = 'Matching variant not found'
     RESERVED_CHARACTER = 'The `@` character is reserved for `account@domain` constructs,' \
                          ' `#` — for `asset#domain` and `$` — for `trigger$domain`.'
-    WHITESPACES = "White space not allowed"
+    WHITESPACES = 'White space not allowed'
+    INSUFFICIENT_FUNDS = 'Not enough quantity to transfer/burn'
 
 
 class ReservedChars(Enum):
@@ -40,6 +41,6 @@ class ValueTypes(Enum):
     """
     QUANTITY = 'Quantity'  # unsigned 32-bit integer
     STORE = 'Store' #storing key-values in object's metadata
-    # BIG_QUANTITY = 'BigQuantity' unsigned 128-bit integer
+    BIG_QUANTITY = 'BigQuantity' #unsigned 128-bit integer
     # FIXED = 'Fixed' 64-bit fixed-precision number with
     # nine significant digits after the decimal point

client_cli/pytests/common/helpers.py

@@ -3,14 +3,65 @@
 """
 
 import binascii
+import json
+import os
 import random
+import re
 import string
 
 from cryptography.hazmat.primitives import serialization
 from cryptography.hazmat.primitives.asymmetric.ed25519 import Ed25519PrivateKey
+
 from common.consts import ReservedChars, fake
 
 
+def extract_hash(stdout):
+    """
+    Extracts a SHA-256 hash from the given string.
+
+    :param stdout: The  string from which to extract the hash.
+    :return: The extracted hash if found, otherwise None.
+    """
+    if not isinstance(stdout, str) or not stdout.strip():
+        return None
+    pattern = r'"([A-Fa-f0-9]{64})"'
+    match = re.search(pattern, stdout)
+    return match.group(1) if match else None
+
+def get_peers_config_files(path_to_configs):
+    """
+    Returns a list of config file paths from the given directory.
+    """
+    config_files = []
+    for entry in os.listdir(path_to_configs):
+        if entry.endswith('.json') and 'config_to_peer' in entry:
+            config_files.append(os.path.join(path_to_configs, entry))
+    return config_files
+
+def read_isi_from_json(file_path):
+    """
+    Reads ISI instruction from a JSON file.
+
+    :param file_path: Path to the JSON file containing ISI instruction.
+    :return: Dictionary with ISI instruction.
+    """
+    with open(file_path, 'r', encoding='utf-8') as file:
+        isi_data = json.load(file)
+    return isi_data
+
+
+def write_isi_to_json(isi_data, file_path):
+    """
+    Writes ISI instruction to a JSON file.
+
+    :param isi_data: Dictionary with ISI instruction.
+    :param file_path: Path to save the JSON file.
+    """
+    if not isinstance(isi_data, list):
+        isi_data = [isi_data]
+    with open(file_path, 'w', encoding='utf-8') as file:
+        json.dump(isi_data, file, indent=4)
+
 def generate_random_string_with_reserved_char():
     """
     Generate a random string with a reserved character.
@@ -55,7 +106,8 @@ def generate_random_string_without_reserved_chars(length):
     """
     Generate a random string with the specified length, excluding reserved characters.
     """
-    allowed_chars = [c for c in [*string.ascii_letters, *string.digits] if c not in ReservedChars.ALL.value]
+    allowed_chars = \
+        [c for c in [*string.ascii_letters, *string.digits] if c not in ReservedChars.ALL.value]
     return generate_random_string(length, allowed_chars)
 
 

client_cli/pytests/common/json_isi_examples/unregister_asset.json

@@ -0,0 +1,7 @@
+[{
+"Unregister": {
+    "Asset": {
+        "object_id": "rose#alice@wonderland"
+    }
+}
+}]

client_cli/pytests/common/settings.py

@@ -4,6 +4,7 @@
 """
 
 import os
+
 from dotenv import load_dotenv
 
 load_dotenv()
@@ -17,6 +18,7 @@
 
 PATH_CONFIG_CLIENT_CLI = os.path.join(ROOT_DIR, "config.json")
 CLIENT_CLI_PATH = os.path.join(ROOT_DIR, "iroha_client_cli")
+PEERS_CONFIGS_PATH = os.path.join(ROOT_DIR, "peers_configs")
 
 PORT_MIN = int(os.getenv('TORII_API_PORT_MIN', '8080'))
 PORT_MAX = int(os.getenv('TORII_API_PORT_MAX', '8083'))

client_cli/pytests/models/account.py

@@ -3,6 +3,7 @@
 """
 from dataclasses import dataclass
 
+
 @dataclass
 class Account:
     """
@@ -17,7 +18,7 @@ class Account:
     """
     name: str
     domain: str
-    public_key: str
+    public_key: str = None
 
     def __repr__(self):
         return f"{self.name}@{self.domain}"

client_cli/pytests/models/asset.py

@@ -4,6 +4,7 @@
 
 from dataclasses import dataclass
 
+
 @dataclass
 class AssetDefinition:
     """
@@ -39,10 +40,13 @@ class Asset:
 
     :param definition: The asset definition of the asset.
     :type definition: AssetDefinition
+    :param account: The account of the asset.
+    :type definition: str
     :param value: The value of the asset.
     :type value: str
     """
     definition: AssetDefinition
+    account: str
     value: str
 
     def __repr__(self):

client_cli/pytests/models/domain.py

@@ -3,6 +3,7 @@
 """
 from dataclasses import dataclass
 
+
 @dataclass
 class Domain:
     """

client_cli/pytests/src/client_cli/__init__.py

@@ -2,7 +2,7 @@
 This module initializes the Iroha client and configuration using environment variables.
 """
 
-from common.settings import PATH_CONFIG_CLIENT_CLI, PORT_MIN, PORT_MAX
+from common.settings import PATH_CONFIG_CLIENT_CLI, PORT_MAX, PORT_MIN
 from src.client_cli.client_cli import ClientCli
 from src.client_cli.configuration import Config
 from src.client_cli.iroha import Iroha