fix(queries): fix more clippy warns

Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>

core/src/query/store.rs

@@ -271,8 +271,8 @@ impl LiveQueryStoreHandle {
     }
 
     /// Remove query from the storage if there is any.
-    pub fn drop_query(&self, query_id: QueryId) {
-        self.store.remove(&query_id);
+    pub fn drop_query(&self, query_id: &QueryId) {
+        self.store.remove(query_id);
     }
 
     fn construct_query_response(

core/src/smartcontracts/isi/query.rs

@@ -227,6 +227,7 @@ impl ValidQueryRequest {
     /// # Errors
     ///
     /// Returns an error if the query execution fails.
+    #[allow(clippy::too_many_lines)] // not much we can do, we _need_ to list all the box types here
     pub fn execute(
         self,
         live_query_store: &LiveQueryStoreHandle,

core/src/smartcontracts/wasm.rs

@@ -282,7 +282,7 @@ fn forget_all_executed_queries(
     executed_queries: impl IntoIterator<Item = QueryId>,
 ) {
     for query_id in executed_queries {
-        query_handle.drop_query(query_id);
+        query_handle.drop_query(&query_id);
     }
 }
 

data_model/src/query/builder.rs

@@ -345,7 +345,7 @@ where
         match (first, second) {
             (None, None) => Ok(None),
             (Some(result), None) => Ok(Some(result)),
-            (Some(_), Some(_)) => Err(SingleQueryError::ExpectedOneOrZeroGotMany.into()),
+            (Some(_), Some(_)) => Err(SingleQueryError::ExpectedOneOrZeroGotMany),
             (None, Some(_)) => {
                 unreachable!()
             }
@@ -358,9 +358,9 @@ where
         let second = iter.next().transpose()?;
 
         match (first, second) {
-            (None, None) => Err(SingleQueryError::ExpectedOneGotNone.into()),
+            (None, None) => Err(SingleQueryError::ExpectedOneGotNone),
             (Some(result), None) => Ok(result),
-            (Some(_), Some(_)) => Err(SingleQueryError::ExpectedOneGotMany.into()),
+            (Some(_), Some(_)) => Err(SingleQueryError::ExpectedOneGotMany),
             (None, Some(_)) => {
                 unreachable!()
             }