Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/streamline repacker list in game cards #1392

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Shisuiicaro
Copy link
Contributor

@Shisuiicaro Shisuiicaro commented Jan 11, 2025

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read and understood the Contributor Guidelines.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:
This PR fix visual pollution in the game card when using multiple sources
image

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced game card display with improved source management by limiting visible repackers and adding a counter for additional sources.

  • Modified /src/renderer/src/components/game-card/game-card.tsx to display max 3 repacker badges with "+N available" counter for remaining sources
  • Added "available" translation key in /src/locales/pt-BR/translation.json for localized display of remaining sources count
  • Removed redundant <ul> wrapper from game card component for cleaner DOM structure
  • Implemented firstThreeRepackers array using slice() for efficient source limiting

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

src/renderer/src/components/game-card/game-card.tsx Outdated Show resolved Hide resolved
@Hachi-R Hachi-R added the enhancement New feature or request label Jan 11, 2025
@Hachi-R Hachi-R changed the title Feature/game card sources Feature/streamline repacker list in game cards Jan 11, 2025
@Hachi-R
Copy link
Collaborator

Hachi-R commented Jan 13, 2025

@greptileai

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes found since last review. The provided files show the same modifications previously covered - limiting repacker badges to three with a counter for additional sources in the game card component, and adding Portuguese translations for the "available" strings.

The previous review accurately captured the key changes and there are no significant new modifications to highlight in this update.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants