-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/streamline repacker list in game cards #1392
base: main
Are you sure you want to change the base?
Feature/streamline repacker list in game cards #1392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Enhanced game card display with improved source management by limiting visible repackers and adding a counter for additional sources.
- Modified
/src/renderer/src/components/game-card/game-card.tsx
to display max 3 repacker badges with "+N available" counter for remaining sources - Added "available" translation key in
/src/locales/pt-BR/translation.json
for localized display of remaining sources count - Removed redundant
<ul>
wrapper from game card component for cleaner DOM structure - Implemented
firstThreeRepackers
array usingslice()
for efficient source limiting
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
…icaro/hydra-pr into Feature/Game-Card-Sources
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
No major changes found since last review. The provided files show the same modifications previously covered - limiting repacker badges to three with a counter for additional sources in the game card component, and adding Portuguese translations for the "available" strings.
The previous review accurately captured the key changes and there are no significant new modifications to highlight in this update.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content:
This PR fix visual pollution in the game card when using multiple sources