Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize org-key, additional logging for troubleshooting #95

Closed
wants to merge 1 commit into from

Conversation

Alan-Huntress
Copy link
Contributor

  • Fixed the script so it handles being passed invalid org-key characters like single quotes
  • Logging version so support can determine if the partner is using an out of date version
  • Additional logging of account keys in edge cases, this helps support troubleshoot why the install failed.
  • Cleanup of code based on suggestions from @uttie-huntress

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Fixed the script so it handles being passed invalid org-key characters like single quotes
* Logging version so support can determine if the partner is using an out of date version
* Additional logging of account keys in edge cases, this helps support troubleshoot why the install failed.
* Cleanup of code based on suggestions from @uttie-huntress
@uttie-huntress
Copy link
Contributor

Hey @Alan-Huntress , I've been going thru my PR requests, and it seems like I missed this (for many months 😞 Apologies).
Are the code changes still relevant? Just want to make sure nothing new since Aug supersedes this work.

@Alan-Huntress
Copy link
Contributor Author

Hey @uttie-huntress ! I believe these changes are needed but the new bash script has some improvements I'd like to wrap into this one, so I'm going to close this and submit a new pull request with everything it needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants