Expand reply-in-private for user.id, custom message #20
Conversation
Allowing the reply-in-private to leverage msg.message.user.id in case duplicate user names are allowed. Allow the use of a custom notification message telling the user that they were replied to in private.
| @@ -56,9 +58,11 @@ helpContents = (name, commands) -> | |||
| """ | |||
|
|
|||
| module.exports = (robot) -> | |||
| replyInPrivate = process.env.HUBOT_HELP_REPLY_IN_PRIVATE | |||
| replyInPrivate = process.env.HUBOT_HELP_REPLY_IN_PRIVATE | |||
| privateNotifMessage = process.env.HUBOT_HELP_PRIVATE_MSG || 'replied to you in private!' | |||
There was a problem hiding this comment.
most replies are structured @${author}, ${msg} from what I've seen on adapters, so it's lowercase to not make those look odd.
There was a problem hiding this comment.
and you can make it whatever you want.
|
I've tested this on hipchat doesn't work. hipchat relies on the jabba id aka jid. We'll need to use I've done a quick test and that worked for hipchat. |
|
user.id can be set to user.jid |
@aliasfalse could you explain where this is? I'm unsure where that can be set. Do you mean the hipchat adapter? |
|
@jonyeezs yeah, that's where i meant. Sorry for not responding. |
|
@aliasfalse i don't see that setting on their readme. I must be blind
…On Sat, 31 Dec 2016, 9:36 AM Tobiah ***@***.***> wrote:
@jonyeezs <https://github.com/jonyeezs> yeah, that's where i meant. Sorry
for not responding.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKXAhlt9KkW76abyAdjhKhtPjWv7offgks5rNZWMgaJpZM4KNF72>
.
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'm pretty sure this would fix #15. Please merge it. |
|
@jonyeezs it's not an option on their readme. enhance the hipchat adapter to map the user jid to the user id. there's no reason to have multiple fields that mean the same thing. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'm pretty sure this would fix #15. Please merge it. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
*sigh* I guess this project has been abandoned. Oh well, last try. I'm pretty sure this would fix #15. Please merge it. |
|
Well, since then the codebase changed from coffeescript to pure js, so the merge is going to need some work. I like the idea to have configurability about how to reply in private though. I may try to tinker on this. |
|
I can go redo it later in pure js. I actually prefer pure js, tbh |
|
i'm gonna close this and re-open on the new fork |
|
Opened #45 |
Allowing the reply-in-private to leverage msg.message.user.id in case duplicate user names are allowed.
Allow the use of a custom notification message telling the user that they were replied to in private.
Also added a listener ID, I think there have been discussions about issues with this, so I can remove it if desired.