TestCore implements TestSpy pattern (#393)

* make TestCore implement the Test Spy pattern and add a test * refactor TestCore query methods * revert 793dce5 but keep the refactored interface
hpi-swa-teaching · Jun 13, 2021 · 5bdd69b · 5bdd69b
1 parent b135684
commit 5bdd69b
Show file tree

Hide file tree

Showing 11 changed files with 58 additions and 4 deletions.
diff --git a/...-Core.package/TCTCAPITests.class/instance/testPositionIsUpdatedAfterInitialChatLoading.st b/...-Core.package/TCTCAPITests.class/instance/testPositionIsUpdatedAfterInitialChatLoading.st
@@ -0,0 +1,16 @@
+testing
+testPositionIsUpdatedAfterInitialChatLoading
+
+	| testChat newChatEvent updatePositionEvent |
+
+	testChat := self sharedCore chats first.
+	self assert: testChat positionKnown.
+
+	newChatEvent := (self sharedCore loggedEventsSatisfying:
+		[:anEvent | anEvent type = 'updateNewChat' and: [((anEvent at: 'chat') at: 'id') = testChat id]])
+		first.
+	updatePositionEvent := (self sharedCore loggedEventsSatisfying:
+		[:anEvent | anEvent type = 'updateChatPosition' and: [(anEvent at: 'chat_id') = testChat id]])
+		first.
+
+	self assert: (self sharedCore chronologicalPositionOf: newChatEvent) < (self sharedCore chronologicalPositionOf: updatePositionEvent).
diff --git a/packages/TelegramClientTests-Core.package/TCTCAPITests.class/methodProperties.json b/packages/TelegramClientTests-Core.package/TCTCAPITests.class/methodProperties.json
@@ -3,4 +3,5 @@
 		 },
 	"instance" : {
 		"testExtraAPIAttribute" : "RS 6/6/2021 10:50",
-		"testMessageSending" : "RS 6/6/2021 10:54" } }
+		"testMessageSending" : "RS 6/6/2021 10:54",
+		"testPositionIsUpdatedAfterInitialChatLoading" : "RS 6/13/2021 17:02" } }
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/README.md b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/README.md
@@ -1 +1 @@
-Creates a TestApp using Telegram TestDatabase Service
+Creates a TestApp using Telegram TestDatabase Service and saves all received events in-order in a log.
diff --git a/.../TelegramClientTests-Core.package/TCTCTestCore.class/instance/chronologicalPositionOf..st b/.../TelegramClientTests-Core.package/TCTCTestCore.class/instance/chronologicalPositionOf..st
@@ -0,0 +1,9 @@
+event log querying
+chronologicalPositionOf: anEvent
+
+	| position |
+
+	position := self eventLog findFirst: [:anotherEvent | anotherEvent = anEvent].
+	self assert: (position = 0) not.
+
+	^ position
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/eventLog..st b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/eventLog..st
@@ -0,0 +1,4 @@
+accessing
+eventLog: anOrderedCollection
+
+	eventLog := anOrderedCollection
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/eventLog.st b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/eventLog.st
@@ -0,0 +1,4 @@
+accessing
+eventLog
+
+	^ eventLog
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/handleEvent..st b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/handleEvent..st
@@ -0,0 +1,5 @@
+events
+handleEvent: anEvent
+
+	self eventLog add: anEvent.
+	^ super handleEvent: anEvent
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/initialize.st b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/instance/initialize.st
@@ -0,0 +1,5 @@
+initialization
+initialize
+
+	self eventLog: OrderedCollection new.
+	super initialize.
diff --git a/...s/TelegramClientTests-Core.package/TCTCTestCore.class/instance/loggedEventsSatisfying..st b/...s/TelegramClientTests-Core.package/TCTCTestCore.class/instance/loggedEventsSatisfying..st
@@ -0,0 +1,4 @@
+event log querying
+loggedEventsSatisfying: aBlock
+
+	^ self eventLog select: aBlock
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/methodProperties.json b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/methodProperties.json
@@ -2,5 +2,11 @@
 	"class" : {
 		 },
 	"instance" : {
+		"chronologicalPositionOf:" : "RS 6/13/2021 17:05",
+		"eventLog" : "RS 6/13/2021 12:31",
+		"eventLog:" : "RS 6/13/2021 12:32",
+		"handleEvent:" : "RS 6/13/2021 12:34",
+		"initialize" : "RS 6/13/2021 12:47",
 		"initializeHandlers" : "JB 6/7/2021 09:27",
+		"loggedEventsSatisfying:" : "RS 6/13/2021 17:06",
 		"loginWithTestData" : "RS 5/26/2021 13:57" } }
diff --git a/packages/TelegramClientTests-Core.package/TCTCTestCore.class/properties.json b/packages/TelegramClientTests-Core.package/TCTCTestCore.class/properties.json
@@ -4,9 +4,9 @@
 		 ],
 	"classvars" : [
 		 ],
-	"commentStamp" : "rs 6/14/2020 12:57",
+	"commentStamp" : "RS 6/13/2021 13:04",
 	"instvars" : [
-		 ],
+		"eventLog" ],
 	"name" : "TCTCTestCore",
 	"pools" : [
 		 ],
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		Creates a TestApp using Telegram TestDatabase Service
		Creates a TestApp using Telegram TestDatabase Service and saves all received events in-order in a log.