Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max depth target #804

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Max depth target #804

merged 6 commits into from
Jan 24, 2025

Conversation

keskitalo
Copy link
Member

Add two new targeting modes to the TOAST scheduler.

@keskitalo keskitalo requested a review from tskisner January 21, 2025 04:32
tskisner
tskisner approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@tskisner tskisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine, but I just wanted to note that this source file is now 3500 lines with minimal docstrings. At some point we should convert this file to a scheduler submodule or similar and pay off some of the technical debt.

@keskitalo keskitalo merged commit 2504340 into toast3 Jan 24, 2025
7 checks passed
@keskitalo keskitalo deleted the max_depth_target branch January 24, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tskisner tskisner tskisner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keskitalo @tskisner