Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jormun]:Intiaize _access_points = false for isochrone #4341

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[jormun]:Intiaize _access_points = false for isochrone #4341

merged 1 commit into from
Jan 15, 2025

Conversation

kadhikari
Copy link
Contributor

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xlqian
Copy link
Member

xlqian commented Jan 15, 2025 •
edited
Loading

can you test a classic isochrone, with only either from or to in the request?

you should also handle this case :)

@kadhikari
Copy link
Contributor Author

can you test a classic isochrone, with only either from or to in the request?

you should also handle this case :)

  • api /journeys with from or to works well in customer as well as production

@kadhikari kadhikari merged commit 4da36db into dev Jan 15, 2025
9 of 10 checks passed
@kadhikari kadhikari deleted the fix_isochrone_with_access_points branch January 15, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien3d adrien3d adrien3d approved these changes

@azime azime Awaiting requested review from azime

@xlqian xlqian Awaiting requested review from xlqian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kadhikari @xlqian @adrien3d