-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add reference(s) for quickstart guide; fix ansible playbook example #198
Open
pathcl
wants to merge
6
commits into
hostinger:main
Choose a base branch
from
pathcl:pathcl/fix-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cd1a4a5
add reference(s) for quickstart guide; fix ansible playbook example
pathcl 9b85c8c
Merge branch 'main' into pathcl/fix-docs
pathcl 915ded6
Merge branch 'main' into pathcl/fix-docs
kazysgurskas 91d8710
Merge branch 'main' into pathcl/fix-docs
pathcl 707cf81
Merge branch 'main' into pathcl/fix-docs
pathcl b7920fc
Merge branch 'main' into pathcl/fix-docs
konradasb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will need separate documentation page, as we also create our own kernel images here. Need to define the differences, I'll handle this upcoming week, then You can update the reference here.
It should work with the one from Firecracker, even though some crucial options will be missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! indeed I downloaded it from there and used it to test fireactions. Im curious what crucial options we would be missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, sorry for the wait, been busy. You can update it to this reference, change the PR title to match conventional commit guidelines (we have squash merge with title as commit message enabled) and it's good to go!
Regarding the differences between kernels - I really can't remember, should have documented when building:( But what I can remember is that it's built off the Firecracker kernel config. I think we had some issues with running Docker/Kubernetes workloads.