Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add marisa-trie #711

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: add marisa-trie #711

merged 1 commit into from
May 8, 2024

Conversation

vermut
Copy link
Contributor

@vermut vermut commented May 8, 2024

We have a small local catastrophe in one of custom components. 3.12 upgrade left us without per-compiled wheel for marisa-trie.
DurgNomis-drol/ha_toyota#258

I did fix that with cross-system QEMU build for aarch64, but armv?l is not supported by that.
pytries/marisa-trie#101
pytries/marisa-trie#102
piwheels/piwheels#346

Maybe this is the correct place to provide a wheel for 32-bit Raspberries?

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vermut

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented May 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 8, 2024 18:48
@vermut vermut marked this pull request as ready for review May 8, 2024 18:50
@home-assistant home-assistant bot dismissed their stale review May 8, 2024 18:51

Stale

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see... we can try!

I'm going to merge this to see the result. If it fails, this might end up being reverted.

../Frenck

@frenck frenck merged commit 80c4d00 into home-assistant:master May 8, 2024
8 checks passed
@vermut vermut deleted the patch-1 branch May 8, 2024 20:08
frenck added a commit that referenced this pull request May 8, 2024
@frenck
Copy link
Member

frenck commented May 8, 2024

@vermut Reverted, see for context: #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants