Add config flow to Roth Touchline #83484

pilehave · 2022-12-07T17:25:40Z

Breaking change

Proposed change

Add setup from config flow
Allow some flexibility on user input of the address of the control unit (with/without http)
Add unique id to each thermostat to allow for area assignement etc.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Missing unique ID on touchline integration #80900
This PR is related to issue:
Link to documentation pull request: Patch 1 home-assistant.io#25863

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

bachya

Additionally, I'm not an expert on how the translations system works, but I don't think this PR should be altering various non-English translations manually.

homeassistant/components/touchline/__init__.py

homeassistant/components/touchline/climate.py

homeassistant/components/touchline/config_flow.py

pilehave · 2022-12-08T10:57:56Z

Additionally, I'm not an expert on how the translations system works, but I don't think this PR should be altering various non-English translations manually.

The "translations"-folder and files in it? Seems to be the way other integratrions are doing it. When I browse the code, most of them has the same folder and a JSON-file for each language. I just copied from a similar integration and removed a unused string from each of them.

bachya · 2022-12-08T14:40:45Z

Integrations don't add those files manually; they are generated by Lokalise automatically. When an integration adds strings.yaml, the PR should only include the English translations file (generated with python3 -m script.translations develop).

pilehave · 2022-12-13T11:18:49Z

I have removed the manually added translations. I don't get why there is a "docs-missing — Please open a documentation PR." failed check. It should be ready to merge?

homeassistant/components/touchline/__init__.py

homeassistant/components/touchline/climate.py

Changes are in home-assistant/core#83484

pilehave · 2023-01-24T21:01:40Z

Documentation has been updated - should be ready to merge this PR as well.

pfwilliam · 2023-02-02T10:06:43Z

Hi @pilehave , any idea on when this update might get released? :) I would love the unique id to be added, so I can add the floor heating to my automations in node red.
thank you for awesome work!

KimCarlsen · 2023-03-02T17:00:42Z

@bachya any comments on this PR? thanks

bachya

Approved once CI is addressed.

epenet

config-flow requires 100% coverage, yet tests are missing.
Please address the missing tests

epenet · 2023-03-22T15:50:44Z

homeassistant/components/touchline/translations/en.json

@@ -0,0 +1,20 @@
+{


This file is no longer necessary. Please remove.

home-assistant · 2023-03-22T15:51:42Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

pilehave · 2023-03-23T08:33:07Z

I don't know how to add tests. Please advice and point to relevant guide in documentation.

KimCarlsen · 2023-04-22T04:27:20Z

@pilehave did you look at the documentation for tests? https://developers.home-assistant.io/docs/development_testing#writing-tests-for-integrations

dehoej · 2023-07-26T18:40:17Z

Is there anything we can do to get this merged?

frenck · 2023-10-06T07:41:50Z

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck

pilehave added 5 commits December 7, 2022 16:19

Add min_temp, max_temp and use controller ID as unique ID

ed21db2

Cleanup after rebase :-/

ba6a2ea

Cleanup after rebase :-/

b17228f

Cleanup after rebase :-/

cee8656

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

806213f

home-assistant bot added cla-signed config-flow This integration migrates to the UI by adding a config flow integration: touchline new-integration Quality Scale: No score labels Dec 7, 2022

pilehave marked this pull request as draft December 7, 2022 17:33

pilehave marked this pull request as ready for review December 7, 2022 17:33

pilehave mentioned this pull request Dec 7, 2022

Add config flow to Roth Touchline #82762

Closed

19 tasks

bachya reviewed Dec 7, 2022

View reviewed changes

pilehave added 3 commits December 8, 2022 06:37

Add missing async_setup_platform

b57acfb

Clean up try/except and remove text in languages

2da17a9

Fix pylint warnings

8a57bd5

pilehave added 3 commits December 9, 2022 10:37

Remove manual translations

ba28195

English translation added

b2527aa

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

00476d8

pilehave mentioned this pull request Dec 13, 2022

Update touchline.markdown home-assistant/home-assistant.io#25270

Closed

8 tasks

pilehave added 2 commits January 3, 2023 13:37

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

9120aa3

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

2f1f555

pilehave requested a review from bachya January 3, 2023 12:56

bachya reviewed Jan 3, 2023

View reviewed changes

pilehave added 2 commits January 8, 2023 21:45

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

9a434d3

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

f314d7b

pilehave added 5 commits January 9, 2023 22:24

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

f1fd3e6

Remove explicit properties and use _attr_ instead

5f86a48

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

944b627

Merge branch 'home-assistant:dev' into Get-controller-id-on-first-setup

537ebd5

Fix URL with missing schema not being saved

6128231

pilehave added a commit to pilehave/home-assistant.io that referenced this pull request Jan 20, 2023

Updates to support changes in integration

71c6572

Changes are in home-assistant/core#83484

This was referenced Jan 20, 2023

Patch 1 home-assistant/home-assistant.io#25863

Closed

Add config flow to Roth Touchline home-assistant/home-assistant.io#25865

Closed

Missing unique ID on touchline integration #80900

Closed

pilehave requested a review from bachya January 24, 2023 21:02

bachya approved these changes Mar 2, 2023

View reviewed changes

epenet requested changes Mar 22, 2023

View reviewed changes

homeassistant/components/touchline/translations/en.json

@@ -0,0 +1,20 @@

{

Copy link

Contributor

epenet Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is no longer necessary. Please remove.

home-assistant bot marked this pull request as draft March 22, 2023 15:51

frenck closed this Oct 6, 2023

github-actions bot locked and limited conversation to collaborators Oct 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add config flow to Roth Touchline #83484

Add config flow to Roth Touchline #83484

pilehave commented Dec 7, 2022 •

edited

Loading

bachya left a comment

pilehave commented Dec 8, 2022

bachya commented Dec 8, 2022

pilehave commented Dec 13, 2022

pilehave commented Jan 24, 2023

pfwilliam commented Feb 2, 2023

KimCarlsen commented Mar 2, 2023

bachya left a comment

epenet left a comment

epenet Mar 22, 2023

home-assistant bot commented Mar 22, 2023

pilehave commented Mar 23, 2023

KimCarlsen commented Apr 22, 2023

dehoej commented Jul 26, 2023

frenck commented Oct 6, 2023

Add config flow to Roth Touchline #83484

Add config flow to Roth Touchline #83484

Conversation

pilehave commented Dec 7, 2022 • edited Loading

Breaking change

Proposed change

Type of change

Additional information

Checklist

bachya left a comment

Choose a reason for hiding this comment

pilehave commented Dec 8, 2022

bachya commented Dec 8, 2022

pilehave commented Dec 13, 2022

pilehave commented Jan 24, 2023

pfwilliam commented Feb 2, 2023

KimCarlsen commented Mar 2, 2023

bachya left a comment

Choose a reason for hiding this comment

epenet left a comment

Choose a reason for hiding this comment

epenet Mar 22, 2023

Choose a reason for hiding this comment

home-assistant bot commented Mar 22, 2023

pilehave commented Mar 23, 2023

KimCarlsen commented Apr 22, 2023

dehoej commented Jul 26, 2023

frenck commented Oct 6, 2023

pilehave commented Dec 7, 2022 •

edited

Loading