-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WLED Palette Selector property #136498
base: dev
Are you sure you want to change the base?
WLED Palette Selector property #136498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Proposed change
Makes a minor change to the WLED integration to update options in the palette selector. Palettes would initially be set once upon entity setup, however the palettes count can change if custom palettes are added. This change makes the options for the palette selector into a property that will update when the device is polled.
An update is required in the underlying library to fully support custom palettes, however the change proposed here are compatible with the existing version. See frenck/python-wled#1603 and frenck/python-wled#1602.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: