Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyvesync to 2.1.16 #136493

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Bump pyvesync to 2.1.16 #136493

merged 3 commits into from
Jan 25, 2025

Conversation

iprak
Copy link
Contributor

@iprak iprak commented Jan 25, 2025

Breaking change

Proposed change

This updates the pyvesync package to 2.1.16 which contains 2 fixes

https://github.com/webdjoe/pyvesync/releases/tag/2.1.16

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
    https://github.com/webdjoe/pyvesync/releases/tag/2.1.16

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @markperdue, @webdjoe, @TheGardenMonkey, @cdnninja, mind taking a look at this pull request as it has been labeled with an integration (vesync) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of vesync can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign vesync Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@iprak iprak changed the title Update use pyvesync 2.1.16 Update Vesync to use pyvesync 2.1.16 Jan 25, 2025
@iprak
Copy link
Contributor Author

iprak commented Jan 25, 2025

The failed test seems to be unrelated.

@Cederick
Copy link

Will this add support for Air Fryers as well down the line like this one I have?
https://cosori.com/collections/air-fryers/products/pro-gen-2-5-8-qt-air-fryer-black
It uses the VeSync app.

@iprak
Copy link
Contributor Author

iprak commented Jan 25, 2025

Will this add support for Air Fryers as well down the line like this one I have? https://cosori.com/collections/air-fryers/products/pro-gen-2-5-8-qt-air-fryer-black It uses the VeSync app.

Yes, the goal is expand the supported devices. However, that would also depend on the devices supported by the underlying pyvesync library and currently I don't see ProGen listed there.

@Cederick
Copy link

Will this add support for Air Fryers as well down the line like this one I have? https://cosori.com/collections/air-fryers/products/pro-gen-2-5-8-qt-air-fryer-black It uses the VeSync app.

Yes, the goal is expand the supported devices. However, that would also depend on the devices supported by the underlying pyvesync library and currently I don't see ProGen listed there.

Well yeah just saw that right now. I just hope that it will automagically be supported as well. Also notide that they call their deviced differently in different countries which is not helpful. It is called COSORI Smart WiFi 5,5-Liter in my country for example and not Pro Gen whatever.

And thank you for taking your time to reply to my comment!

@thecode thecode changed the title Update Vesync to use pyvesync 2.1.16 Bump pyvesync to 2.1.16 Jan 25, 2025
@thecode thecode merged commit 1bf97e3 into home-assistant:dev Jan 25, 2025
44 checks passed
@iprak
Copy link
Contributor Author

iprak commented Jan 25, 2025

Will this add support for Air Fryers as well down the line like this one I have? https://cosori.com/collections/air-fryers/products/pro-gen-2-5-8-qt-air-fryer-black It uses the VeSync app.

Yes, the goal is expand the supported devices. However, that would also depend on the devices supported by the underlying pyvesync library and currently I don't see ProGen listed there.

Well yeah just saw that right now. I just hope that it will automagically be supported as well. Also notide that they call their deviced differently in different countries which is not helpful. It is called COSORI Smart WiFi 5,5-Liter in my country for example and not Pro Gen whatever.

And thank you for taking your time to reply to my comment!

I think that would depend on what that device internally is and what does it end up mapping to. This mapping defines the device behavior.

@iprak iprak deleted the bump-pyvesync-2.1.16 branch January 25, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants