-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Whirlpool tests into a parameterized test #136490
base: dev
Are you sure you want to change the base?
Conversation
Hey there @mkmer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
) | ||
async def test_form_auth_error( | ||
exception: Exception, | ||
expected_error: str, | ||
hass: HomeAssistant, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have hass as the first parameter
@@ -81,7 +91,7 @@ async def test_form_cannot_connect( | |||
DOMAIN, context={"source": config_entries.SOURCE_USER} | |||
) | |||
|
|||
mock_auth_api.return_value.do_auth.side_effect = aiohttp.ClientConnectionError | |||
mock_auth_api.return_value.do_auth.side_effect = exception | |||
result2 = await hass.config_entries.flow.async_configure( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reuse result
) | ||
assert result2["type"] is FlowResultType.FORM | ||
assert result2["errors"] == {"base": "unknown"} | ||
assert result2["errors"] == {"base": expected_error} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also directly make this test finish in a CREATE ENTRY to also test that it's able to recover
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
SSIA
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: