Add diagnostic sensors for the active subscription of Cookidoo #136485
+313
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zweckj
requested changes
Jan 25, 2025
Comment on lines
+62
to
+64
| value_fn=lambda data: dt_util.parse_datetime(data.subscription.expires) | ||
| if data.subscription | ||
| else None, |
There was a problem hiding this comment.
Suggested change
| value_fn=lambda data: dt_util.parse_datetime(data.subscription.expires) | |
| if data.subscription | |
| else None, | |
| value_fn=( | |
| lambda data: dt_util.parse_datetime(data.subscription.expires) | |
| if data.subscription | |
| else None | |
| ), |
| "subscription": { | ||
| "name": "Subscription", | ||
| "state": { | ||
| "none": "None", |
There was a problem hiding this comment.
because you mentioned differently: Is it "Free" or "None"?
There was a problem hiding this comment.
it is free access which means no subscription. not sure what is clearer to uderstand for the user
There was a problem hiding this comment.
Personally, I think I'd prefer "Free". What's it called in the app?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds diagnostic sensors for the cookidoo subscription to track the subscription type
none|trial|regularand the expiration date.Paid subscription
Free access
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: