Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flow data descriptions to ring integration #136464

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add config flow data descriptions to ring integration #136464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/ring/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ async def async_step_reauth_confirm(
errors=errors,
description_placeholders={
CONF_USERNAME: reauth_entry.data[CONF_USERNAME],
CONF_NAME: reauth_entry.data[CONF_USERNAME],
CONF_NAME: reauth_entry.title,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

},
)

Expand Down
13 changes: 13 additions & 0 deletions homeassistant/components/ring/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,26 +6,39 @@
"data": {
"username": "[%key:common::config_flow::data::username%]",
"password": "[%key:common::config_flow::data::password%]"
},
"data_description": {
"username": "Your Ring cloud username.",
"password": "Your Ring cloud password."
Comment on lines +11 to +12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's "Ring account", not "Ring cloud". Let's be consistent in the strings and also match what Ring calls it on their website.

}
},
"2fa": {
"title": "Two-factor authentication",
"data": {
"2fa": "Two-factor code"
},
"data_description": {
"2fa": "Account verification code via the method selected in your ring account settings."
}
},
"reauth_confirm": {
"title": "[%key:common::config_flow::title::reauth%]",
"description": "The Ring integration needs to re-authenticate your account {username}",
"data": {
"password": "[%key:common::config_flow::data::password%]"
},
"data_description": {
"password": "[%key:component::ring::config::step::user::data_description::password%]"
}
},
"reconfigure": {
"title": "Reconfigure Ring Integration",
"description": "Will create a new Authorized Device for {username} at ring.com",
"data": {
"password": "[%key:common::config_flow::data::password%]"
},
"data_description": {
"password": "[%key:component::ring::config::step::user::data_description::password%]"
}
}
},
Expand Down