-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use typed ConfigEntry in ring coordinator #136457
base: dev
Are you sure you want to change the base?
Conversation
*, | ||
config_entry: RingConfigEntry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make this a keyword argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s a kwarg in the base class so this is consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's that way in the base because it originally was an optional argument with a default. In your derived implementation, it is required and has no default, so it should be a positional argument. I suggest putting it after the hass
parameter, so the HA related components come first, followed by the ring API:
def __init__(
self,
hass: HomeAssistant,
config_entry: RingConfigEntry,
ring_api: Ring,
) -> None:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make config_entry
and positional argument in both coordinators. Thanks you!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
SSIA
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: