Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unique ID on touchline integration #80900

Closed
KimCarlsen opened this issue Oct 24, 2022 · 8 comments · May be fixed by #136473
Closed

Missing unique ID on touchline integration #80900

KimCarlsen opened this issue Oct 24, 2022 · 8 comments · May be fixed by #136473

Comments

@KimCarlsen
Copy link

The problem

Touchline integration does not generate unique ids as per https://www.home-assistant.io/faq/unique_id

What version of Home Assistant Core has the issue?

2022.10.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

touchline

Link to integration documentation on our website

https://www.home-assistant.io/integrations/touchline/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

@KimCarlsen
Copy link
Author

@pilehave any comments on this?

@pilehave
Copy link
Contributor

pilehave commented Nov 9, 2022

Should be simple to add unique_id to be generated, as pytouchline returns the device ID with get_device_id().
My internet at home has been down for a week and a half, but will be able to test this in the weekend.

If You are bold enough, I have linked to a new version of climate.py for the component. Be sure to make a backup of the old version to restore if the new one doesn't work ;-)

https://cm3.dk/climate.py

@KimCarlsen
Copy link
Author

awesome. it works.
note: there are some indentation errors at line 77 & 87

Thanks

@pilehave
Copy link
Contributor

pilehave commented Nov 10, 2022

awesome. it works. note: there are some indentation errors at line 77 & 87

Thanks

Great!
I just whipped it together on Notepad++, so indentation is my fault. There was one on line 99 as well (fixed now).

Too bad that the new Touchline units are different from the old ones, regarding the embedded webserver, it would be nice to support them as well. But as I don't have the new one, I can't really do much.

@KimCarlsen
Copy link
Author

That would be nice to support the new one as well. But i don't want to buy it before there is support in HA.

Do you make a PR on this?

@pilehave
Copy link
Contributor

pilehave commented Dec 4, 2022

I have been working on it for a while, ended up putting configuration in a config flow as well as fixing the "unique id" thing.
Pullrequest: #83484

@issue-triage-workflows
Copy link

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@issue-triage-workflows issue-triage-workflows bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.