Make Go2RtcRestClient.validate_server_version a classmethod #17
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 97.85% 97.87% +0.02%
==========================================
Files 7 7
Lines 280 283 +3
Branches 46 48 +2
==========================================
+ Hits 274 277 +3
Misses 4 4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
emontnemery
force-pushed
the
validate_server_version_classmethod
branch
from
4bd3b28 to
776173f
Compare
emontnemery
added
the
enhancement
| async def validate_server_version(self) -> None: | ||
| async def validate_server_version( | ||
| cls, websession: ClientSession, server_url: str | ||
| ) -> None: |
There was a problem hiding this comment.
Is this really more convenient? Won't this just mean we have to pass the session and url twice to two calls instead of passing them once to the first of two calls, when validating the server version and creating a client? We also just save two instance creation calls out of four internally compared to creating the client from the beginning.
There was a problem hiding this comment.
I had the same discussion with Robert. From the user's point of view, I think it makes sense to make it a class method; there's no need for a client if the server has the wrong version.
From the current implementation point of view it's as you say currently not useful since the implementation creates the client objects.
At the same time, the client objects are very lightweight and cost very little to create.
|
I'm closing this since both @MartinHjelmare and @edenhaus think it's a bad idea |
Proposed Changes
Make
Go2RtcRestClient.validate_server_versiona classmethod; the method will be called before a client is created to validate the serverRelated Issues