Don't use dtype=object when converting arrays to pass to shapely 2 (#103

) * Don't use dtype=object when converting arrays to pass to shapely 2 * Force shapely>=2.0 in CI * Increase CI timeout * Revert shapely pin
holoviz · Dec 15, 2022 · b3d7ba1 · b3d7ba1
1 parent 26cfd93
commit b3d7ba1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -19,7 +19,7 @@ jobs:
       matrix:
         os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
         python-version: [3.7, 3.8, 3.9, '3.10']
-    timeout-minutes: 60
+    timeout-minutes: 90
     defaults:
       run:
         shell: bash -l {0}

diff --git a/spatialpandas/geometry/multipolygon.py b/spatialpandas/geometry/multipolygon.py
@@ -59,7 +59,7 @@ def to_shapely(self):
             shapely MultiPolygon shape
         """
         import shapely.geometry as sg
-        polygon_arrays = np.asarray(self.data.as_py(), dtype=object)
+        polygon_arrays = self.data.as_py()
 
         polygons = []
         for polygon_array in polygon_arrays:

diff --git a/spatialpandas/geometry/polygon.py b/spatialpandas/geometry/polygon.py
@@ -61,7 +61,7 @@ def to_shapely(self):
         """
         import shapely.geometry as sg
         ring_arrays = [np.asarray(line_coords).reshape(len(line_coords) // 2, 2)
-                       for line_coords in np.asarray(self.data.as_py(), dtype=object)]
+                       for line_coords in self.data.as_py()]
         rings = [sg.LinearRing(ring_array) for ring_array in ring_arrays]
         return sg.Polygon(shell=rings[0], holes=rings[1:])