Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIH-11091 - replace Faker.NetCore with Bogus #1459

Merged
merged 4 commits into from
Jan 10, 2025
Merged

VIH-11091 - replace Faker.NetCore with Bogus #1459

merged 4 commits into from
Jan 10, 2025

Conversation

marcogagliardi
Copy link
Contributor

Jira link

VIH-11091

Change description

removed Faker.NetCore

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@marcogagliardi marcogagliardi requested review from a team as code owners January 6, 2025 11:30
oliver-scott
oliver-scott reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@oliver-scott oliver-scott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a comment about the new file

AdminWebsite/AdminWebsite/AdminWebsite.sln Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ronaldmalone
ronaldmalone approved these changes Jan 10, 2025
View reviewed changes
Copy link

@ronaldmalone ronaldmalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No QA required

@marcogagliardi marcogagliardi merged commit 3642202 into master Jan 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldmalone ronaldmalone ronaldmalone approved these changes

@oliver-scott oliver-scott oliver-scott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcogagliardi @oliver-scott @ronaldmalone