CME-116 update rd-commons-lib #1708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-wolski
requested changes
Nov 7, 2024
lukasz-wolski
previously approved these changes
Nov 8, 2024
* Fix serenity issues * Remove unused classes
build.gradle
Outdated
Comment on lines
596
to
608
| dependencyUpdates.resolutionStrategy = { | ||
| componentSelection { rules -> | ||
| rules.all { ComponentSelection selection -> | ||
| boolean rejected = ['alpha', 'beta', 'rc', 'cr', 'm'].any { qualifier -> | ||
| selection.candidate.version ==~ /(?i).*[.-]${qualifier}[.\d-]*/ | ||
| } | ||
| if (rejected) { | ||
| selection.reject('Release candidate') | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
resolution strategy ensures only released versions are being used. why is it being removed?
There was a problem hiding this comment.
Good spot, my mistake. This should've stayed.
lukasz-wolski
requested changes
Dec 18, 2024
lukasz-wolski
previously approved these changes
Dec 18, 2024
AntonyLeons
previously approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://tools.hmcts.net/jira/browse/CME-200
Change description
Update to be able to use updated rd-commons-lib