Dtsrd 2140 #1583
Dtsrd 2140 #1583
Conversation
* DTSRD-2525: handle flyway out of order * DTSRD-2525: handle flyway out of order
| log.info("deletePbaOfExistingOrganisationShouldBeForbiddenWhenLDOff :: STARTED"); | ||
|
|
||
| setUpTestData(); | ||
| String bearerToken = inviteUser(puiFinanceManager, intActiveOrgId, generateRandomEmail(), |
There was a problem hiding this comment.
dont need to invite another user to delete payment account ? for internal endpoint prd-admin only allowed to delete payment account.
| deletePbaRequest.setPaymentAccounts(Set.of("PBA0000021", "PBA0000022", "PBA0000023")); | ||
|
|
||
| professionalApiClient.deletePaymentAccountsOfOrganisation(deletePbaRequest, | ||
| professionalApiClient.getMultipleAuthHeaders(bearerToken), BAD_REQUEST); |
There was a problem hiding this comment.
incorrect status code bad request, api should return 403 when feature is toggled off
| String intActiveOrgId = createAndActivateOrganisationWithGivenRequest(organisationCreationRequest, | ||
| hmctsAdmin); | ||
|
|
||
| String bearerToken = inviteUser(puiFinanceManager, intActiveOrgId, generateRandomEmail(), |
There was a problem hiding this comment.
dont need to invite finance manager user to delete payment account, remove this line
| log.info("deletePbaOfExistingOrganisationShouldBeForbiddenWhenLDOff :: END"); | ||
| } | ||
|
|
||
| public String inviteUser(String role, |
There was a problem hiding this comment.
this method not required, remove it
| PbaRequest deletePbaRequest = new PbaRequest(); | ||
| deletePbaRequest.setPaymentAccounts(Set.of("PBA0000021", "PBA0000022", "PBA0000023")); | ||
|
|
||
| professionalApiClient.deletePaymentAccountsOfOrganisation(deletePbaRequest, |
There was a problem hiding this comment.
this line making a call to existing external endpoint, so this test is invalid. make change to call new internal endpoint with prd-admin user
| PbaRequest deletePbaRequest = new PbaRequest(); | ||
| deletePbaRequest.setPaymentAccounts(organisationCreationRequest.getPaymentAccount()); | ||
|
|
||
| professionalApiClient.deletePaymentAccountsOfOrganisation(deletePbaRequest, |
There was a problem hiding this comment.
this line making a call to existing external endpoint, so this test is invalid. make change to call new internal endpoint with prd-admin user
| deletePbaRequest.setPaymentAccounts(organisationCreationRequest.getPaymentAccount()); | ||
|
|
||
| professionalApiClient.deletePaymentAccountsOfOrganisation(deletePbaRequest, | ||
| professionalApiClient.getMultipleAuthHeaders(bearerToken), NO_CONTENT); |
There was a problem hiding this comment.
wrong user token used, it should be prd-user token
|
|
||
| @Operation( | ||
| summary = "Deletes the provided list of payment accounts from the organisation.", | ||
| description = "**IDAM Roles to access API** : <br> - pui-finance-manager", |
There was a problem hiding this comment.
wrong role , it should be prd-admin
Jira link (if applicable)
Change description
Checklist