DTSRD-2136. Update Name for a given organisation #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabinaHMCTS
changed the title
SabinaHMCTS
force-pushed
the
DTSRD-2136
branch
from
edc0631 to
f6ce243
Compare
rajkatla-hmcts
requested changes
Feb 29, 2024
src/main/java/uk/gov/hmcts/reform/professionalapi/service/impl/OrganisationServiceImpl.java
Outdated
Show resolved
Hide resolved
.../uk/gov/hmcts/reform/professionalapi/controller/internal/OrganisationInternalController.java
Outdated
Show resolved
Hide resolved
src/main/java/uk/gov/hmcts/reform/professionalapi/service/impl/OrganisationServiceImpl.java
Outdated
Show resolved
Hide resolved
...egrationTest/java/uk/gov/hmcts/reform/professionalapi/UpdateOrgNameSraIdIntegrationTest.java
Outdated
Show resolved
Hide resolved
...egrationTest/java/uk/gov/hmcts/reform/professionalapi/UpdateOrgNameSraIdIntegrationTest.java
Outdated
Show resolved
Hide resolved
...nalTest/java/uk/gov/hmcts/reform/professionalapi/ProfessionalInternalUserFunctionalTest.java
Outdated
Show resolved
Hide resolved
rajkatla-hmcts
previously approved these changes
Sep 11, 2024
.../uk/gov/hmcts/reform/professionalapi/controller/internal/OrganisationInternalController.java
Outdated
Show resolved
Hide resolved
...gov/hmcts/reform/professionalapi/controller/internal/OrganisationInternalControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/uk/gov/hmcts/reform/professionalapi/service/impl/OrganisationServiceImplTest.java
Outdated
Show resolved
Hide resolved
| responseEntity = restTemplate.exchange(urlPath, HttpMethod.PUT, requestEntity, Map.class); | ||
|
|
||
| } catch (RestClientResponseException ex) { | ||
| HashMap<String, Object> statusAndBody = new HashMap<>(2); |
There was a problem hiding this comment.
minor: map creation could be replaced by using Map.of(k1, v1, k2, v2) factory method
| return statusAndBody; | ||
| } | ||
|
|
||
| Map<String, Object> organisationResponse = new HashMap<>(); |
There was a problem hiding this comment.
minor: map creation could be replaced by using Map.of(k1, v1, k2, v2) factory method
lukasz-wolski
previously approved these changes
Sep 12, 2024
SabinaHMCTS
dismissed stale reviews from lukasz-wolski and rajkatla-hmcts
via
9efcae0
… redundant assert checks
lukasz-wolski
previously approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
Change description
Checklist