Add some more tests for legacy data marshalling #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
2 times, most recently
from
6a9ab98 to
2ef4cd4
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
from
2ef4cd4 to
35e7793
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
from
35e7793 to
2359f29
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
from
2359f29 to
a6004c8
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
2 times, most recently
from
e3204e5 to
52886fa
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
from
52886fa to
99ff5a5
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
from
99ff5a5 to
380bb00
Compare
RustyHMCTS
force-pushed
the
PO-118-extra-tests
branch
from
380bb00 to
16dd466
Compare
sabahirfan
reviewed
Jan 23, 2024
sabahirfan
reviewed
Jan 23, 2024
src/main/java/uk/gov/hmcts/opal/dto/legacy/DefendantAccountSearchCriteria.java
Outdated
Show resolved
Hide resolved
sabahirfan
reviewed
Jan 23, 2024
| public class DefendantAccountSearchCriteriaTest { | ||
|
|
||
| @Test | ||
| public void testBuilder() throws InterruptedException { |
There was a problem hiding this comment.
In my opinion we don't need to write unit tests for the generated code. The config we have (lombok.addLombokGeneratedAnnotation = true) already helps tools to not include in coverage calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a breaking change? (check one with "x")