Optimise code (#201)

* Optimise code * Optimise code * Optimise code
hmcts · Feb 19, 2024 · 0274b5b · 0274b5b
1 parent c943f02
commit 0274b5b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -171,11 +171,11 @@ jacocoTestReport {
 
 static String[] jacocoExclusionArray(ArrayList<String> exclusions)
 {
-  final def lst = new ArrayList<String>();
+  final def lst = new ArrayList<String>()
 
   exclusions.stream().forEach {it.endsWith(".java") ? lst.add(it.replace(".java", ".class")) : lst.add(it)}
 
-  return lst.toArray();
+  return lst.toArray()
 }
 
 project.tasks['sonarqube'].dependsOn jacocoTestReport

diff --git a/src/main/java/uk/gov/hmcts/opal/repository/jpa/EntitySpecs.java b/src/main/java/uk/gov/hmcts/opal/repository/jpa/EntitySpecs.java
@@ -6,6 +6,7 @@
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
 
@@ -31,9 +32,7 @@ public final List<Specification<E>> specificationList(List<Optional<Specificatio
     @SafeVarargs
     public final List<Optional<Specification<E>>> combine(List<Optional<Specification<E>>> specsList,
                                                           Optional<Specification<E>>... optionalSpecs) {
-        for (Optional<Specification<E>> spec: optionalSpecs) {
-            specsList.add(spec);
-        }
+        Collections.addAll(specsList, optionalSpecs);
         return specsList;
     }
 

diff --git a/src/test/java/uk/gov/hmcts/opal/service/opal/DefendantAccountServiceTest.java b/src/test/java/uk/gov/hmcts/opal/service/opal/DefendantAccountServiceTest.java
@@ -329,7 +329,7 @@ public static AccountDetailsDto buildAccountDetailsDto() {
             .postCode("W1 1AA")
             .dob(LocalDate.of(1979,12,12))
             .detailsChanged(LocalDate.of(2012, 1,1))
-            .lastCourtAppAndCourtCode(LocalDate.of(2012, 1,1).toString()
+            .lastCourtAppAndCourtCode(LocalDate.of(2012, 1,1)
                                           + " " + 1212)
             .lastMovement(LocalDate.of(2012, 1,1))
             .commentField(List.of("Comment1"))