Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency webpack-dev-middleware to v6 [SECURITY] #783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 7, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
webpack-dev-middleware ^5.3.4 -> ^6.0.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29180

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem.
If writeToDisk configuration option is set to true, the physical filesystem is used:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path.
The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath:
https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82
As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js:
module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd:
$ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, Allow-Access-Origin: * ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.


Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware)

v6.1.2

Compare Source

6.1.2 (2024-03-20)
Bug Fixes

v6.1.1

Compare Source

v6.1.0

Compare Source

Features
Bug Fixes
6.0.2 (2023-03-19)
Bug Fixes
6.0.1 (2022-11-28)
Bug Fixes

v6.0.2

Compare Source

v6.0.1

Compare Source

v6.0.0

Compare Source

⚠ BREAKING CHANGES
  • minimum supported webpack version is 5.0.0
  • minimum supported Nodejs version is 14.15.0
5.3.3 (2022-05-18)
Bug Fixes
5.3.2 (2022-05-17)
Bug Fixes
5.3.1 (2022-02-01)
Bug Fixes

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 7, 2024 05:44
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Aug 7, 2024
@renovate renovate bot requested a review from justiceia August 7, 2024 05:44
@renovate renovate bot enabled auto-merge (rebase) August 7, 2024 05:44
renovate-approve[bot]
renovate-approve bot previously approved these changes Aug 7, 2024
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Aug 7, 2024
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 2 times, most recently from f064a1f to fd15240 Compare September 20, 2024 07:41
@renovate renovate bot enabled auto-merge (rebase) September 20, 2024 14:03
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from fd15240 to faa5f4a Compare September 20, 2024 14:06
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from faa5f4a to ab11870 Compare September 20, 2024 14:58
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from ab11870 to 4008a5f Compare October 9, 2024 08:36
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 4008a5f to cc71532 Compare October 29, 2024 14:56
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from cc71532 to 4ea4797 Compare November 8, 2024 09:37
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 4ea4797 to 6bc42e5 Compare November 11, 2024 09:53
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 6bc42e5 to 9141576 Compare November 28, 2024 08:59
@renovate renovate bot changed the title Update dependency webpack-dev-middleware to v6 [SECURITY] Update dependency webpack-dev-middleware to v6 [SECURITY] - autoclosed Dec 8, 2024
@renovate renovate bot closed this Dec 8, 2024
auto-merge was automatically disabled December 8, 2024 18:35

Pull request was closed

@renovate renovate bot deleted the renovate/npm-webpack-dev-middleware-vulnerability branch December 8, 2024 18:35
@renovate renovate bot changed the title Update dependency webpack-dev-middleware to v6 [SECURITY] - autoclosed Update dependency webpack-dev-middleware to v6 [SECURITY] Dec 8, 2024
@renovate renovate bot reopened this Dec 8, 2024
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch 3 times, most recently from 1d88523 to ade8152 Compare December 9, 2024 17:06
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from ade8152 to a300289 Compare December 10, 2024 13:17
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from a300289 to 414a925 Compare December 11, 2024 15:53
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 414a925 to 437e2e6 Compare December 12, 2024 16:15
@renovate renovate bot force-pushed the renovate/npm-webpack-dev-middleware-vulnerability branch from 437e2e6 to 32d763c Compare January 15, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ns:fact prd:fact rel:fact-frontend-pr-783
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants