tab hash link fix #1271
Merged
tab hash link fix #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
mhaack
reviewed
Nov 8, 2023
| @@ -24,6 +37,7 @@ function buildNav(block) { | |||
| const listItem = li( | |||
| { | |||
| class: 'tabs-nav-item', | |||
| id: tabTitle.toLowerCase().split(' ').join('-'), | |||
There was a problem hiding this comment.
You can use toClassName helper here this will also handle special characters etc.
There was a problem hiding this comment.
@mhaack Code changes has been done as per provided suggestions.
…nto tab-hash-links
|
|
|
|
mhaack
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: