added bundle and thumbnail in RFQ #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
mhaack
reviewed
Nov 9, 2023
Comment on lines
179
to
185
| if (data.bundleThumbnail) { | ||
| if (!data.bundleThumbnail.startsWith('https')) { | ||
| if (data.bundleThumbnail.startsWith('.')) { | ||
| data.bundleThumbnail = data.bundleThumbnail.substring(1); | ||
| } | ||
| data.bundleThumbnail = `https://www.moleculardevices.com${data.bundleThumbnail}`; | ||
| } |
There was a problem hiding this comment.
Since this logic is similar to the product image we should move that to a function instead of duplication.
There was a problem hiding this comment.
Function hasThumbnailImage created for the same
mhaack
requested changes
Nov 9, 2023
| if (data.path) { | ||
| hubSpotQuery.website = `https://www.moleculardevices.com${data.path}`; | ||
| } else { | ||
| hubSpotQuery.website = `https://www.moleculardevices.com${data.toLowerCase()}`; |
There was a problem hiding this comment.
Does this work? Data is an object white multiple fields. I think we can set the website to the hose only allready when hubSpotQuery is created above and only if data.path exists we append it.
There was a problem hiding this comment.
Agreed, else part removed!
|
|
|
|
mhaack
reviewed
Nov 9, 2023
| @@ -130,9 +130,20 @@ function iframeResizehandler(formUrl, id, root) { | |||
| }); | |||
| } | |||
|
|
|||
| function hasThumbnailImage(thumbImage) { | |||
There was a problem hiding this comment.
maybe rename to prepImageUrl
There was a problem hiding this comment.
Done @mhaack
mhaack
approved these changes
Nov 9, 2023
|
|
|
mhaack
approved these changes
Nov 9, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: