Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fragment Block added #232

Merged
merged 4 commits into from
May 24, 2024
Merged

Fragment Block added #232

merged 4 commits into from
May 24, 2024

Conversation

jindaliiita
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix

Test URLs:

Copy link

aem-code-sync bot commented May 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 21, 2024

Page Scores Audits Google
/drafts/piyush/fragment-block PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bstopp
Copy link
Collaborator

bstopp commented May 23, 2024

Is this needed for another PR? I don't see any use of it anywhere.

@rrusher
Copy link
Collaborator

rrusher commented May 23, 2024

Is this needed for another PR? I don't see any use of it anywhere.

I'm using it for the side modal forms.

@jindaliiita jindaliiita merged commit 2361c70 into main May 24, 2024
2 checks passed
@bstopp bstopp deleted the fragment branch June 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants