Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agent Testimonials carousel #231

Merged
merged 11 commits into from
May 28, 2024
Merged

Add Agent Testimonials carousel #231

merged 11 commits into from
May 28, 2024

Conversation

RitwikSrivastava
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #159

Test URLs:

Copy link

aem-code-sync bot commented May 20, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented May 20, 2024

Page Scores Audits Google
/drafts/ritsriva/nancy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 20, 2024 05:43 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 20, 2024 06:13 Inactive
@RitwikSrivastava RitwikSrivastava requested a review from bstopp May 20, 2024 06:14
@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 20, 2024 17:21 Inactive
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this block to be 'agent-testimonials' or something as carousel is too generic.

Update the fetch to use a page metadata property that is the agent ID as discussed.

For the draft page, only have this block on the page to check it's PSI score in a stand-alone context.

Ritwik Srivastava and others added 2 commits May 21, 2024 15:29
@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 22, 2024 06:35 Inactive
@RitwikSrivastava RitwikSrivastava changed the title Add Testimonials carousel Add Agent Testimonials carousel May 22, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 22, 2024 06:36 Inactive
@RitwikSrivastava RitwikSrivastava requested a review from bstopp May 22, 2024 06:36
@RitwikSrivastava
Copy link
Collaborator Author

Please change this block to be 'agent-testimonials' or something as carousel is too generic.

Update the fetch to use a page metadata property that is the agent ID as discussed.

For the draft page, only have this block on the page to check it's PSI score in a stand-alone context.

Updated to incorporate the above review points.

blocks/agent-testimonials/agent-testimonials.js Outdated Show resolved Hide resolved
blocks/agent-testimonials/agent-testimonials.js Outdated Show resolved Hide resolved
blocks/agent-testimonials/agent-testimonials.js Outdated Show resolved Hide resolved
blocks/agent-testimonials/agent-testimonials.css Outdated Show resolved Hide resolved
@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 27, 2024 06:11 Inactive
@RitwikSrivastava RitwikSrivastava requested a review from bstopp May 27, 2024 06:16
@aem-code-sync aem-code-sync bot temporarily deployed to ritsriva-carousel May 27, 2024 06:16 Inactive
@RitwikSrivastava RitwikSrivastava merged commit b83459a into main May 28, 2024
2 checks passed
@bstopp bstopp deleted the ritsriva-carousel branch June 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent Template - Agent Testimonial
2 participants