Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hero-banner-updates: style updates to hero banner and property search #217

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

schooolman
Copy link
Collaborator

Addressing the styling updates to the hero banner and container search bar to match new site designs.

Test URLs:

@schooolman schooolman requested a review from bstopp April 18, 2024 17:56
Copy link

aem-code-sync bot commented Apr 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 18, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@@ -81,7 +81,11 @@ async function buildForm() {
</div>
</div>
<button class="filter" type="button" aria-label="More Filters" aria-haspopup="true">
<span class="icon icon-filter"></span>
<span class="icon icon-filter">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to be careful with this - the icon keyword in a span will auto-fill the children with a reference to an SVG icon. if you want to use a literal, you need to remove/change these class names.

or replcae the filter.svg icon file with the contents of the added sprite, and remove all children nodes here.

see the decorateIcons function link

@aem-code-sync aem-code-sync bot temporarily deployed to hero-banner-updates April 26, 2024 18:12 Inactive
@schooolman schooolman merged commit 0d60ecd into main Apr 29, 2024
2 checks passed
@bstopp bstopp deleted the hero-banner-updates branch May 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants