Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luxury Collection Hero Listing Slider #187

Merged
merged 13 commits into from
Jan 18, 2024
Merged

Luxury Collection Hero Listing Slider #187

merged 13 commits into from
Jan 18, 2024

Conversation

rrusher
Copy link
Collaborator

@rrusher rrusher commented Dec 11, 2023

@rrusher rrusher self-assigned this Dec 11, 2023
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 11, 2023 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 11, 2023

Page Scores Audits Google
/drafts/rrusher/luxury-hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rrusher rrusher changed the title starter hero slides Luxury Collection Hero Listing Slider Dec 11, 2023
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 3, 2024 •
edited
Loading

Page Scores Audits Google
/drafts/rrusher/luxury-hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rrusher rrusher marked this pull request as ready for review January 16, 2024 15:50
@rrusher rrusher requested a review from bstopp January 16, 2024 15:51
@rrusher
Copy link
Collaborator Author

rrusher commented Jan 16, 2024

This still needs an API call to return the featured properties. It is stubbed out for now in fetchListings() on line 4.

bstopp
bstopp reviewed Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luxury_Real_Estate___BHHS_Commonwealth_Real_Estate

Do you know why the mark svg isn't rendering?

@rrusher
Copy link
Collaborator Author

rrusher commented Jan 17, 2024

Yes. The lux template is interfering. I'll fix and resubmit.

@rrusher rrusher requested a review from bstopp January 17, 2024 23:38
@rrusher rrusher merged commit 6d8ed43 into main Jan 18, 2024
2 checks passed
@bstopp bstopp deleted the 93-hero-slides branch May 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstopp bstopp bstopp approved these changes

Assignees

@rrusher rrusher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property Listing Carousel full-width page
2 participants
@rrusher @bstopp