Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fonts #47

Merged
merged 3 commits into from
Dec 19, 2023
Merged

add fonts #47

merged 3 commits into from
Dec 19, 2023

Conversation

kronnox
Copy link
Collaborator

@kronnox kronnox commented Dec 19, 2023

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 19, 2023 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Dec 19, 2023 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kronnox kronnox requested review from bstopp and tmaret December 19, 2023 10:56
@kronnox kronnox mentioned this pull request Dec 19, 2023
Closed
tmaret
tmaret previously approved these changes Dec 19, 2023
View reviewed changes
kailasnadh790
kailasnadh790 previously approved these changes Dec 19, 2023
View reviewed changes
bstopp
bstopp requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@bstopp bstopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the Fallback font face definitions to the styles.css - the font.css file is loaded after all the blocks are displayed, which can cause CLS issue.

@kronnox kronnox dismissed stale reviews from kailasnadh790 and tmaret via f0bd9d8 December 19, 2023 16:10
@kronnox
Copy link
Collaborator Author

kronnox commented Dec 19, 2023

Please move the Fallback font face definitions to the styles.css - the font.css file is loaded after all the blocks are displayed, which can cause CLS issue.

Makes sense, done!

@kronnox kronnox requested a review from bstopp December 19, 2023 16:15
@kronnox kronnox merged commit 378c5fb into main Dec 19, 2023
2 checks passed
@kronnox kronnox deleted the issue/46 branch January 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstopp bstopp bstopp approved these changes

@kailasnadh790 kailasnadh790 kailasnadh790 left review comments

@tmaret tmaret tmaret left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import fonts
4 participants
@kronnox @tmaret @bstopp @kailasnadh790