Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home page link references. #128

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix home page link references. #128

merged 3 commits into from
Jan 24, 2024

Conversation

bstopp
Copy link
Collaborator

@bstopp bstopp commented Jan 24, 2024

Copy link

aem-code-sync bot commented Jan 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@bstopp bstopp requested a review from kailasnadh790 January 24, 2024 17:36
Copy link

aem-code-sync bot commented Jan 24, 2024

Page Scores Audits Google
/cigaradvisor PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@@ -71,7 +71,7 @@ export default async function decorate(block) {
topNavLeft.classList.add('top-nav-left');
topNavContent.append(topNavLeft);
const brand = document.createElement('div');
brand.innerHTML = `<a href="/cigaradvisor/" rel="home" class="layout__logo lg-andUp" title="Cigar Advisor Homepage">
brand.innerHTML = `<a href="/cigaradvisor" rel="home" class="layout__logo lg-andUp" title="Cigar Advisor Homepage">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar change needed in hero.js as well

@kailasnadh790 kailasnadh790 merged commit 71a2fa5 into main Jan 24, 2024
2 checks passed
@bstopp bstopp deleted the bug/home-link branch January 28, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HomePage is /cigaradvisor - no trailing slash
2 participants