Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix author-card styling issues #123

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix author-card styling issues #123

merged 3 commits into from
Jan 24, 2024

Conversation

kronnox
Copy link
Collaborator

@kronnox kronnox commented Jan 24, 2024 •
edited by bstopp
Loading

@kronnox kronnox requested a review from kailasnadh790 January 24, 2024 15:41
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 24, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 24, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

kailasnadh790
kailasnadh790 reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@kailasnadh790 kailasnadh790 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
In mobile, each author card should take 100% width.

@bstopp
Copy link
Collaborator

bstopp commented Jan 24, 2024

image In mobile, each author card should take 100% width.

I am not sure i agree with this, Those images are huge and this looks way better IMO

@bstopp bstopp merged commit 5f6fa18 into main Jan 24, 2024
2 checks passed
@bstopp bstopp deleted the issue/93 branch January 24, 2024 18:22
@kronnox
Copy link
Collaborator Author

kronnox commented Jan 25, 2024

In mobile, each author card should take 100% width.

@kailasnadh790 At least for me, this is not the case on the original site. That's why I changed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailasnadh790 kailasnadh790 kailasnadh790 left review comments

@bstopp bstopp bstopp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Author card: Long author names not wrapping correctly
3 participants
@kronnox @bstopp @kailasnadh790