Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various style and logic issues. #118

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Fix various style and logic issues. #118

merged 3 commits into from
Jan 24, 2024

Conversation

bstopp
Copy link
Collaborator

@bstopp bstopp commented Jan 24, 2024

@bstopp bstopp requested a review from kailasnadh790 January 24, 2024 02:12
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 24, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 24, 2024 •
edited
Loading

Page Scores Audits Google
/cigaradvisor/ Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404) PSI
/cigaradvisor/author/john-pullo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cigaradvisor/fragments/404 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/cigaradvisor/posts/2023/12/top-10-best-new-cigars-of-2023 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kailasnadh790
Copy link
Collaborator

may be we can re-visit the pages once the article-teaser changes are merged to this branch.

@bstopp bstopp marked this pull request as draft January 24, 2024 16:56
@bstopp bstopp marked this pull request as ready for review January 24, 2024 16:58
kailasnadh790
kailasnadh790 approved these changes Jan 24, 2024
View reviewed changes
cigaradvisor/blocks/article-list/article-list.js
@@ -27,7 +27,7 @@ export default async function decorate(block) {
});
await Promise.all(promises).then((result) => {
result.forEach((detail) => {
if (detail) tmp.push(detail);
if (detail && detail.length > 0) tmp.push(detail[0]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

article list not rendering..

@bstopp bstopp merged commit 9236059 into main Jan 24, 2024
2 checks passed
@bstopp bstopp deleted the bug/styles branch January 24, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailasnadh790 kailasnadh790 kailasnadh790 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bstopp @kailasnadh790