Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: use default sheets and named config files #262

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

sirugh
Copy link
Collaborator

@sirugh sirugh commented Dec 13, 2024

Long ago we had, in starter content, a single config file with multiple named sheets within. These were prod, stage, and dev.

Since then, so that merchants can lock down their staging or dev configs, we have moved the configurations from sheets to files.

This ?sheet=prod is a remnant of before, and left to ensure backward compatibility. However going forward, merchants should either use the multiple sheets or the config service.

Merging this change may impact merchants who have the single config file, and who do not split their config files before applying this change.

Test URLs:

Copy link

aem-code-sync bot commented Dec 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 13, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@sirugh sirugh changed the title use default sheets and named config files content: use default sheets and named config files Dec 15, 2024
@herzog31 herzog31 added the changelog Important when updating projects label Dec 16, 2024
@herzog31 herzog31 self-requested a review December 16, 2024 08:23
@aem-code-sync aem-code-sync bot temporarily deployed to remove-config-sheets December 16, 2024 15:55 Inactive
@sirugh sirugh merged commit 8acdea0 into main Dec 16, 2024
3 checks passed
@sirugh sirugh deleted the remove-config-sheets branch December 16, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Important when updating projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants