ASSETS-88888 : Add 'Select All' button on Collections Details and Share Link Page #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/blocks/adp-infinite-results-collection/adp-infinite-results-collection.js : Added the functions selectAllAsets() and deselectAllAssets() which is used in adp-collection-header.js
…tain the Select All Items button
… box /blocks/adp-infinite-results-linkshare/adp-infinite-results-linkshare.js : Added the functions selectAllAssets() and deselectAllAssets()
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
shiv-gup
requested changes
Mar 1, 2024
/blocks/adp-collection-header/adp-collection-header.css : Removed Todo comment /blocks/adp-collection-header/adp-collection-header.js : Changed back to await deleteCollection(collectionId, collection.title); /blocks/adp-share-header/adp-share-header.css: Removed redundant CSS classes
…om the adp-collections-header.js
shiv-gup
reviewed
Mar 4, 2024
… and Remove Item from Multi Select
|
Added additional logic to uncheck the Select All Checkbox when the Banner is Closed and when an Item is deselected. |
mathieu-lessard
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Couple changes.
@shiv-gup once approved, these can be merge'd into main this Thursday any time from 7am to noon PST.
…import statement and refactored select-all-checkbox event listener /blocks/adp-share-header/adp-share-header.js => Removed extra div, refactored select-all-checkbox event listener
shiv-gup
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Jira Ticket has been created for this task
Here is the Workfront Ticket
https://experience.adobe.com/#/@wfadoberm/so:adoberm-Production/workfront/team/64120499002edcb6e4ef1dbc3e644241/iterations
Test URLs:
For Collection Detail with Select All
For Share Link with Select All
https://assets-88888--adobe-gmo--hlxsites.hlx.page/qa/share/1db300fb-db2d-4f51-8705-814514973aa0
Authoring instructions.
Edit the asset-distribution-portal>share>default.docx page and add the block adp-share-header