Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to Main: Feature PM-730 Aggregator Widget Update #302

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

hero-dokane
Copy link
Collaborator

Jira Ticket

PM-730

Purpose / Changes

  • Removed extra conditionals
  • Set up live url for widget

Validate Changes

  1. In order to test locally, update the aggregator widget by putting "dev-" before "quote" urls
  2. View the 'pet-insurance' page, about half way down the page, confirm the aggregator widget is loading / functioning correctly

@hero-dokane hero-dokane self-assigned this Dec 17, 2024
Copy link

aem-code-sync bot commented Dec 17, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Dec 17, 2024

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@pgilmore-phi pgilmore-phi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked on local, looks good

@hero-dokane hero-dokane merged commit 93add57 into main Dec 18, 2024
3 checks passed
@hero-dokane hero-dokane deleted the feature/PM-730-agg-widget-update branch December 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants