Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Sprint 24 Deploy to Main #286

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

hero-dokane
Copy link
Collaborator

Jira Ticket

PM-698

Purpose / Changes

PM-698
Update redirect logic to go to either US or CA thank you page.

Validate Changes

PM-698

  1. Go to the "Found Pet Report" page.
  2. Complete and submit the form.
  3. Observe the redirection behavior after submission.

Copy link

aem-code-sync bot commented Nov 21, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Nov 21, 2024

Page Scores Audits Google
📱 /lost-pet-protection/report-lost-found-pet PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /lost-pet-protection/report-lost-found-pet PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@pgilmore-phi pgilmore-phi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgilmore-phi pgilmore-phi merged commit ac02c8f into main Nov 21, 2024
1 of 2 checks passed
pgilmore-phi added a commit that referenced this pull request Nov 26, 2024
* Initial setup for Costco Figo campaign

* PM-367: Added form and summary logic accomodating promo requirements

* PM-367: Updated logic based on multipet and active promo

* PM-367: Added checks on multipet to identify if we need to clear cookie and data

* PM-367: Added method to disable field, prevent any mouse interactions and disable focus

* PM-367: Added nullish checks on summary page

* PM-367: removing edits to eslint

* PM-367: Adding env config for service

* PM-367: Updated config to proxy service

* PM-367: moving reset method into costo-promo.js

* PM-367: adding removed comment back

* PM-367: remove unnecessary additional check on policyId

* PM-698: update redirect logic (#284) (#286)

* PM-367: Updating subid value for costco figo

* PM-375: Removing type from eligibility rules

* PM-375: Adding console logs for testing

* PM-375: Rename localStorage key for promo

* PM-375: Adding annotations

* PM-375: remove console logs used for testing

---------

Co-authored-by: hero-dokane <[email protected]>
pgilmore-phi added a commit that referenced this pull request Nov 27, 2024
* Initial setup for Costco Figo campaign

* PM-367: Added form and summary logic accomodating promo requirements

* PM-367: Updated logic based on multipet and active promo

* PM-367: Added checks on multipet to identify if we need to clear cookie and data

* PM-367: Added method to disable field, prevent any mouse interactions and disable focus

* PM-367: Added nullish checks on summary page

* PM-367: removing edits to eslint

* PM-367: Adding env config for service

* PM-367: Updated config to proxy service

* PM-367: moving reset method into costo-promo.js

* PM-367: adding removed comment back

* PM-367: remove unnecessary additional check on policyId

* PM-698: update redirect logic (#284) (#286)

* PM-367: Updating subid value for costco figo

* PM-375: Removing type from eligibility rules

* PM-375: Adding console logs for testing

* PM-375: Rename localStorage key for promo

* PM-375: Adding annotations

* PM-375: remove console logs used for testing

* PM-375: add additional css prop for safari to prevent user-select on disabled field

---------

Co-authored-by: hero-dokane <[email protected]>
pgilmore-phi added a commit that referenced this pull request Dec 4, 2024
* Initial setup for Costco Figo campaign

* PM-367: Added form and summary logic accomodating promo requirements

* PM-367: Updated logic based on multipet and active promo

* PM-367: Added checks on multipet to identify if we need to clear cookie and data

* PM-367: Added method to disable field, prevent any mouse interactions and disable focus

* PM-367: Added nullish checks on summary page

* PM-367: removing edits to eslint

* PM-367: Adding env config for service

* PM-367: Updated config to proxy service

* PM-367: moving reset method into costo-promo.js

* PM-367: adding removed comment back

* PM-367: remove unnecessary additional check on policyId

* PM-698: update redirect logic (#284) (#286)

* PM-367: Updating subid value for costco figo

* PM-375: Removing type from eligibility rules

* PM-375: Adding console logs for testing

* PM-375: Rename localStorage key for promo

* PM-375: Adding annotations

* PM-375: remove console logs used for testing

* PM-375: add additional css prop for safari to prevent user-select on disabled field

* PM-375: Added additional promo price comment key value used on conditional check

---------

Co-authored-by: hero-dokane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants