generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Sprint 24 Deploy to Main #286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
pgilmore-phi
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pgilmore-phi
added a commit
that referenced
this pull request
Nov 26, 2024
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-698: update redirect logic (#284) (#286) * PM-367: Updating subid value for costco figo * PM-375: Removing type from eligibility rules * PM-375: Adding console logs for testing * PM-375: Rename localStorage key for promo * PM-375: Adding annotations * PM-375: remove console logs used for testing --------- Co-authored-by: hero-dokane <[email protected]>
pgilmore-phi
added a commit
that referenced
this pull request
Nov 27, 2024
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-698: update redirect logic (#284) (#286) * PM-367: Updating subid value for costco figo * PM-375: Removing type from eligibility rules * PM-375: Adding console logs for testing * PM-375: Rename localStorage key for promo * PM-375: Adding annotations * PM-375: remove console logs used for testing * PM-375: add additional css prop for safari to prevent user-select on disabled field --------- Co-authored-by: hero-dokane <[email protected]>
pgilmore-phi
added a commit
that referenced
this pull request
Dec 4, 2024
* Initial setup for Costco Figo campaign * PM-367: Added form and summary logic accomodating promo requirements * PM-367: Updated logic based on multipet and active promo * PM-367: Added checks on multipet to identify if we need to clear cookie and data * PM-367: Added method to disable field, prevent any mouse interactions and disable focus * PM-367: Added nullish checks on summary page * PM-367: removing edits to eslint * PM-367: Adding env config for service * PM-367: Updated config to proxy service * PM-367: moving reset method into costo-promo.js * PM-367: adding removed comment back * PM-367: remove unnecessary additional check on policyId * PM-698: update redirect logic (#284) (#286) * PM-367: Updating subid value for costco figo * PM-375: Removing type from eligibility rules * PM-375: Adding console logs for testing * PM-375: Rename localStorage key for promo * PM-375: Adding annotations * PM-375: remove console logs used for testing * PM-375: add additional css prop for safari to prevent user-select on disabled field * PM-375: Added additional promo price comment key value used on conditional check --------- Co-authored-by: hero-dokane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
PM-698
Purpose / Changes
PM-698
Update redirect logic to go to either US or CA thank you page.
Validate Changes
PM-698