Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Release/Sprint 23 to Develop #279

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

hero-dokane
Copy link
Collaborator

@hero-dokane hero-dokane commented Nov 13, 2024

Jira Ticket

PM-637
PM-652
PM-694

Changes

PM-637:

  • Remove hard-coded content where applicable so that it can be editable.

PM-652:

  • Update CSS to fix elements overlapping on Step 1 of the Membership Form.

PM-694:

  • 'callout get a quote': delete dir / files
  • 'default block': add dir / files
  • 'paid blog page': styling updates
  • 'pumpkin wellness club': add empty js file :(

Validate Changes

PM-637:
Correlate SharePoint content with the coded output.

PM-652:
Observe the form label / inputs for the microchip number and promo code to ensure there is no overlap.

PM-694:
Check the following urls and ensure there is no css / js files causing 404 errors in the dev tools console.


@hero-dokane hero-dokane self-assigned this Nov 13, 2024
Copy link

aem-code-sync bot commented Nov 13, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Collaborator

@pgilmore-phi pgilmore-phi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgilmore-phi pgilmore-phi merged commit 6b9a875 into develop Nov 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants